You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/08/31 20:34:24 UTC

[Impala-ASF-CR] [DOCS] Changed the Dita output format to XHTML

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11375


Change subject: [DOCS] Changed the Dita output format to XHTML
......................................................................

[DOCS] Changed the Dita output format to XHTML

Changed the output format to XHTML to work around a bug that
generates an incorrect ids for sub-concepts. The bug prevented
cross-referencing sections within docs.

Change-Id: I26084fc8a2fe180093c61a105613791a49865732
---
M docs/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/11375/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] [DOCS] Changed the Dita output format to XHTML

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11375 )

Change subject: [DOCS] Changed the Dita output format to XHTML
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/63/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Aug 2018 20:34:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Changed the Dita output format to XHTML

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11375 )

Change subject: [DOCS] Changed the Dita output format to XHTML
......................................................................


Patch Set 1: Code-Review+2

Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/11375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Sat, 01 Sep 2018 00:41:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Changed the Dita output format to XHTML

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11375 )

Change subject: [DOCS] Changed the Dita output format to XHTML
......................................................................

[DOCS] Changed the Dita output format to XHTML

Changed the output format to XHTML to work around a bug that
generates an incorrect ids for sub-concepts. The bug prevented
cross-referencing sections within docs.

Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Reviewed-on: http://gerrit.cloudera.org:8080/11375
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Jim Apple <jb...@apache.org>
---
M docs/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>

[Impala-ASF-CR] [DOCS] Changed the Dita output format to XHTML

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11375 )

Change subject: [DOCS] Changed the Dita output format to XHTML
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/63/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26084fc8a2fe180093c61a105613791a49865732
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 20:48:55 +0000
Gerrit-HasComments: No