You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/03 13:22:37 UTC
[GitHub] [airflow] zaimy opened a new pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
zaimy opened a new pull request #21293:
URL: https://github.com/apache/airflow/pull/21293
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In an environment using apache-airflow-providers-google 6.3.0, BigQueryDataTransferServiceTransferRunSensor received "400 Invalid transfer run name." from the Google Cloud API and the task will fail.
The run name is defined as a request parameter in BiqQueryDataTransferServiceHook.get_transfer_run(), but there seems to be a typo in the f-string. This pull request fix it.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#issuecomment-1031097974
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #21293:
URL: https://github.com/apache/airflow/pull/21293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#issuecomment-1029060378
Can you add tests also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#issuecomment-1028986014
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zaimy commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
zaimy commented on pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#issuecomment-1029072721
Yes, I'll try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zaimy commented on a change in pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
zaimy commented on a change in pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#discussion_r800333850
##########
File path: tests/providers/google/cloud/hooks/test_bigquery_dts.py
##########
@@ -106,3 +107,13 @@ def test_start_manual_transfer_runs(self, service_mock):
retry=None,
timeout=None,
)
+
+ @mock.patch(
+ "airflow.providers.google.cloud.hooks.bigquery_dts."
+ "DataTransferServiceClient.get_transfer_run"
+ )
+ def test_get_transfer_run(self, service_mock):
+ self.hook.get_transfer_run(transfer_config_id=TRANSFER_CONFIG_ID, project_id=PROJECT_ID)
Review comment:
@mik-laj
Sorry, I did not pass the run_id.
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21293: Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21293:
URL: https://github.com/apache/airflow/pull/21293#issuecomment-1032194740
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org