[jira] Commented: (OFBIZ-515) Replace string comparison with != or == by .equals

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472877 ] 

Jacques Le Roux commented on OFBIZ-515:
---------------------------------------

Thanks Stefan,

I replaced in PaidInOut.java but can't do it anymore in Framework (new PMC policy).

> Replace string comparison with != or == by .equals
> --------------------------------------------------
>
>                 Key: OFBIZ-515
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-515
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacopo Cappellato
>         Attachments: ofbiz_string_compare.diff, ofbiz_string_compare2.diff
>
>
> Attached patch converts several string comparisons to use the standard .equals form as it is not clear in the code
> that the special check if both string point to exactly same object is applicable there.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.