You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/09 12:13:45 UTC
[PR] test(metrics): pin the metric collection scope invariants [rocketmq-dashboard]
zjncs opened a new pull request, #5826:
URL: https://github.com/apache/rocketmq-dashboard/pull/5826
### What
`MetricCollectionScope` identifies one successful native metric collection scope. It had no test. This adds 7 tests.
### What is pinned
- validation: a **null domain**, a **missing or blank instanceId**, an **empty key set** and a **blank metric key** are all rejected;
- **the key set is defensively copied** — mutating the source set after construction does not widen the scope;
- **`contains` matches only when domain, instance and key all agree**, and rejects a null sample.
### Verification
- New tests on unmodified code: **7/7 green**, checkstyle clean.
- Discriminating mutation: the domain check dropped from `contains` (red).
- Restored: 7/7 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the metric collection scope invariants [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #5826: test(metrics): pin the metric collection scope invariants
URL: https://github.com/apache/rocketmq-dashboard/pull/5826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the metric collection scope invariants [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #5826:
URL: https://github.com/apache/rocketmq-dashboard/pull/5826#issuecomment-6755010531
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org