You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2012/02/09 15:54:09 UTC
svn commit: r1242347 -
/subversion/trunk/subversion/tests/libsvn_subr/stream-test.c
Author: philip
Date: Thu Feb 9 14:54:08 2012
New Revision: 1242347
URL: http://svn.apache.org/viewvc?rev=1242347&view=rev
Log:
* subversion/tests/libsvn_subr/stream-test.c
(test_stream_base64_2): Add explanation.
Modified:
subversion/trunk/subversion/tests/libsvn_subr/stream-test.c
Modified: subversion/trunk/subversion/tests/libsvn_subr/stream-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/stream-test.c?rev=1242347&r1=1242346&r2=1242347&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_subr/stream-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_subr/stream-test.c Thu Feb 9 14:54:08 2012
@@ -572,6 +572,11 @@ test_stream_base64(apr_pool_t *pool)
triggers the problem reported here:
http://mail-archives.apache.org/mod_mbox/subversion-dev/201202.mbox/%3C87sjik3m8q.fsf@stat.home.lan%3E
+
+ The two data writes caused the base 64 code to allocate a buffer
+ that was a byte short but exactly matched a stringbuf blocksize.
+ That meant the stringbuf didn't overallocate and a write beyond
+ the end of the buffer occured.
*/
static svn_error_t *
test_stream_base64_2(apr_pool_t *pool)