You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Mikhail Stepura (JIRA)" <ji...@apache.org> on 2013/12/05 06:16:39 UTC
[jira] [Commented] (CASSANDRA-6418) auto_snapshots are not
removable via 'nodetool clearsnapshot'
[ https://issues.apache.org/jira/browse/CASSANDRA-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839830#comment-13839830 ]
Mikhail Stepura commented on CASSANDRA-6418:
--------------------------------------------
{code} [javac] C:\Users\mishail\workspace\cassandra\src\java\org\apache\cassandra\db\compaction\CompactionManager.java:810: error: cannot find symbol
[javac] cfs.clearSnapshot(snapshotName);
[javac] ^
[javac] symbol: method clearSnapshot(String)
[javac] location: variable cfs of type ColumnFamilyStore
{code}
For *getAllKSDirectories*
* {{List<File> snapshotDirs = new ArrayList();}} .It's a raw data type. You probably meant either {{newArrayList()}} or {{new ArrayList<>()}}
* {{new File(dataDirectory + "/" + ksName)}} and {{File(dataDirectory + "/" + ksName + "/" + cfDir)}} - you should use {{org.apache.cassandra.db.Directories.join(String...)}} instead that concatenation.
* I think it would be better to use one of {{File.listFiles}} methods instead of {{File.list()}}
> auto_snapshots are not removable via 'nodetool clearsnapshot'
> -------------------------------------------------------------
>
> Key: CASSANDRA-6418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6418
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: auto_snapshot: true
> Reporter: J. Ryan Earl
> Assignee: Lyuben Todorov
> Priority: Minor
> Fix For: 2.0.4
>
> Attachments: 6418_cassandra-2.0.patch
>
>
> Snapshots of deleted CFs created via the "auto_snapshot" configuration parameter appear to not be tracked. The result is that 'nodetool clearsnapshot <keyspace with deleted CFs>' does nothing, and short of manually removing the files from the filesystem, deleted CFs remain indefinitely taking up space.
> I'm not sure if this is intended, but it seems pretty counter-intuitive. I haven't found any documentation that indicates "auto_snapshots" would be ignored by 'nodetool clearsnapshot'.
--
This message was sent by Atlassian JIRA
(v6.1#6144)