You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/05 02:29:59 UTC

[kudu-CR] [master] turn off client location assignment by default 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17024


Change subject: [master] turn off client location assignment by default
......................................................................

[master] turn off client location assignment by default

This patch turns off location assignment by default to clients
connecting to a Kudu cluster.  The assigned locations are cached,
but the way how locations assignment performed is resource consuming,
see [1] for details.

There aren't many benefits in assigning locations to clients so far:
the only nice property of a client with assigned location vs a client
with no location assigned is that former case the client run from a
particular location would choose tablet servers in the same location
if performing scan in ReplicaSelection::CLOSEST_REPLICA mode.

This is a first step towards addressing KUDU-3212.

[1] https://issues.apache.org/jira/browse/KUDU-3212

Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
4 files changed, 14 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/17024/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................

[master] turn off client location assignment by default

This patch turns off location assignment by default to clients
connecting to a Kudu cluster.  The assigned locations are cached,
but the way how locations assignment performed is resource consuming,
see [1] for details.

There aren't many benefits in assigning locations to clients so far:
the only nice property of a client with assigned location vs a client
with no location assigned is that former case the client run from a
particular location would choose tablet servers in the same location
if performing scan in ReplicaSelection::CLOSEST_REPLICA mode.

This is a first step towards addressing KUDU-3212.

[1] https://issues.apache.org/jira/browse/KUDU-3212

Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Reviewed-on: http://gerrit.cloudera.org:8080/17024
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
5 files changed, 19 insertions(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, but someone else must approve
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17024

to look at the new patch set (#3).

Change subject: [master] turn off client location assignment by default
......................................................................

[master] turn off client location assignment by default

This patch turns off location assignment by default to clients
connecting to a Kudu cluster.  The assigned locations are cached,
but the way how locations assignment performed is resource consuming,
see [1] for details.

There aren't many benefits in assigning locations to clients so far:
the only nice property of a client with assigned location vs a client
with no location assigned is that former case the client run from a
particular location would choose tablet servers in the same location
if performing scan in ReplicaSelection::CLOSEST_REPLICA mode.

This is a first step towards addressing KUDU-3212.

[1] https://issues.apache.org/jira/browse/KUDU-3212

Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
5 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/17024/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master] turn off client location assignment by default

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG@11
PS3, Line 11: resource consuming
> Right: clients do not actively participate in location assignment, the only
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Feb 2021 22:55:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG@20
PS2, Line 20: This is a first step towards addressing KUDU-3212.
Is the plan to improve client location assignment to the point that it can remain enabled by default? If so, maybe we can keep this patch on hand but not merge it if the work can be completed before the next release?



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Feb 2021 14:17:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG@20
PS2, Line 20: This is a first step towards addressing KUDU-3212.
> I am okay to commit this as is for now given we have seen it cause issues i
Thank you!  Yes, I think it won't hurt to have this disabled until there are few first steps towards KUDU-3212 implemented.  We can easily revert this patch, when needed.



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 03:53:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG@11
PS3, Line 11: resource consuming
From KUDU-3212:

> Implementation-wise, Kudu masters could use newly introduced Subprocess functionality to run location assignment script. That would be more robust than using current fork/exec approach to run the script, especially for larger deployments where Kudu masters might have high request-per-second ratio (many active threads running, a lot of memory allocated, etc.)

In short, fork/exec isn't a good idea for busy multi-thread processes.



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 06 Feb 2021 06:08:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG@20
PS2, Line 20: This is a first step towards addressing KUDU-3212.
> Is the plan to improve client location assignment to the point that it can 
Yep, that might be an option.  However, I'm not exactly sure of the priorities for the nearest future.  I guess we can discuss it offline.


http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc@88
PS2, Line 88: By default they do if the location assignment command is set
> nit: needs an update? Probably worth making the description agnostic to whe
Nice catch!

Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Feb 2021 23:36:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG@11
PS3, Line 11: resource consuming
> From KUDU-3212:
Thanks for the explanation! So this is only master side resource consumption but not client side?



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Feb 2021 19:33:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17024

to look at the new patch set (#2).

Change subject: [master] turn off client location assignment by default
......................................................................

[master] turn off client location assignment by default

This patch turns off location assignment by default to clients
connecting to a Kudu cluster.  The assigned locations are cached,
but the way how locations assignment performed is resource consuming,
see [1] for details.

There aren't many benefits in assigning locations to clients so far:
the only nice property of a client with assigned location vs a client
with no location assigned is that former case the client run from a
particular location would choose tablet servers in the same location
if performing scan in ReplicaSelection::CLOSEST_REPLICA mode.

This is a first step towards addressing KUDU-3212.

[1] https://issues.apache.org/jira/browse/KUDU-3212

Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
5 files changed, 18 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/17024/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master] turn off client location assignment by default

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG@11
PS3, Line 11: resource consuming
Sorry, can you elaborate that a bit more? is t resource consuming on masters or clients? I looked into KUDU-3212, but wasn't able to find description related to this. Or maybe I missed it?



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 06 Feb 2021 05:50:26 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 1:

> Build Failed
 > 
 > http://jenkins.kudu.apache.org/job/kudu-gerrit/23284/ : FAILURE

Whoops, forgot we have Java tests as well.  Will fix those and re-post.


-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Feb 2021 05:25:52 +0000
Gerrit-HasComments: No

[kudu-CR] [master] turn off client location assignment by default

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3: Code-Review+1

Looks good to me, but I am not sure if Grant or Andrew have other thoughts on it.


-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Feb 2021 22:56:02 +0000
Gerrit-HasComments: No

[kudu-CR] [master] turn off client location assignment by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/3//COMMIT_MSG@11
PS3, Line 11: resource consuming
> Thanks for the explanation! So this is only master side resource consumptio
Right: clients do not actively participate in location assignment, the only store the result (usually just a short string, like an absolute file path).



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Feb 2021 21:38:16 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG@20
PS2, Line 20: This is a first step towards addressing KUDU-3212.
> Yep, that might be an option.  However, I'm not exactly sure of the priorit
I am okay to commit this as is for now given we have seen it cause issues in larger deployments. We can figure out the timing or re-enabling it with a better solution going forward.



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 02:56:30 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc@88
PS2, Line 88: By default they do if the location assignment command is set
nit: needs an update? Probably worth making the description agnostic to whether it's set to true or false



-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Feb 2021 19:32:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] turn off client location assignment by default

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 02:56:37 +0000
Gerrit-HasComments: No