You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/10 19:55:01 UTC
[jira] [Commented] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205634#comment-13205634 ]
jiraposter@reviews.apache.org commented on FLUME-960:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3837/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
TestAvroSink fails often for two reasons:
1) We call close before the socket has started
2) We call sink.process before the socket has shutdown
This puts a small sleep into fix those two issues.
This addresses bug FLUME-960.
https://issues.apache.org/jira/browse/FLUME-960
Diffs
-----
flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java a46acc0
Diff: https://reviews.apache.org/r/3837/diff
Testing
-------
After the change, I ran the test 120 times and it passed 120 times.
Thanks,
Brock
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Reporter: Brock Noland
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira