You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Timothy Chen <tn...@gmail.com> on 2013/12/08 09:06:55 UTC
Re: Review Request 15824: Patch for DRILL-281
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15824/
-----------------------------------------------------------
(Updated Dec. 8, 2013, 8:06 a.m.)
Review request for drill.
Changes
-------
Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.
Bugs: DRILL-281
https://issues.apache.org/jira/browse/DRILL-281
Repository: drill-git
Description (updated)
-------
Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java b8a7247
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 040a495
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastExchange.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java e1fb3ae
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java e9b56db
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java 4ce826c
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestBroadcastExchange.java PRE-CREATION
exec/java-exec/src/test/resources/sender/broadcast_exchange.json PRE-CREATION
exec/java-exec/src/test/resources/sender/broadcast_exchange_long_run.json PRE-CREATION
Diff: https://reviews.apache.org/r/15824/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 15824: Patch for DRILL-281
Posted by Timothy Chen <tn...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15824/
-----------------------------------------------------------
(Updated Dec. 8, 2013, 8:07 a.m.)
Review request for drill and Jacques Nadeau.
Bugs: DRILL-281
https://issues.apache.org/jira/browse/DRILL-281
Repository: drill-git
Description
-------
Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java b8a7247
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 040a495
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastExchange.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java e1fb3ae
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java e9b56db
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java 4ce826c
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestBroadcastExchange.java PRE-CREATION
exec/java-exec/src/test/resources/sender/broadcast_exchange.json PRE-CREATION
exec/java-exec/src/test/resources/sender/broadcast_exchange_long_run.json PRE-CREATION
Diff: https://reviews.apache.org/r/15824/diff/
Testing
-------
Thanks,
Timothy Chen