You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/11/03 04:04:25 UTC
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4924
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
[kudu-spark] Clean up some build warnings from Scala 2.11
The new Spark 2.x with Scala 2.11 build has more warnings than the
old Spark 1.x with Scala 2.10 one. This patch fixes them. No new
or altered functionality.
Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
---
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
3 files changed, 14 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4924/1
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
[kudu-spark] Clean up some build warnings from Scala 2.11
The new Spark 2.x with Scala 2.11 build has more warnings than the
old Spark 1.x with Scala 2.10 one. This patch fixes them. No new
or altered functionality.
Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Reviewed-on: http://gerrit.cloudera.org:8080/4924
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-spark/pom.xml
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
3 files changed, 14 insertions(+), 12 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
Patch Set 1:
Confirmed warnings gone.
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4924/1/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:
Line 170: <version>1.12</version>
Why was this necessary?
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4924/1/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:
Line 170: <version>1.12</version>
> Why was this necessary?
Maven warning.
--
To view, visit http://gerrit.cloudera.org:8080/4924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8d9095fc7e361da1c02098411ce4088d6d743a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes