You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 16:13:07 UTC

[GitHub] [airflow] rconroy293 commented on issue #7120: [AIRFLOW-6522] Clear log file to fix duplication in S3TaskHandler

rconroy293 commented on issue #7120: [AIRFLOW-6522] Clear log file to fix duplication in S3TaskHandler
URL: https://github.com/apache/airflow/pull/7120#issuecomment-573741775
 
 
   > Trying to think if there are any edge cases to this (such as cases where the upload fails and we might loose the log?)
   > 
   > Can't think of any immediate ones, so LGTM.
   
   The other option I considered was downloading the existing log from S3 into the file first (i.e. on initialization of the logger). If that succeeds, it can just overwrite with the local file. If it fails, it can use the existing append technique. Not sure your thoughts on that @ashb 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services