You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by denis-aes <gi...@git.apache.org> on 2014/04/08 16:45:16 UTC

[GitHub] cordova-plugin-inappbrowser pull request: Update index.md

GitHub user denis-aes opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/36

    Update index.md

    Fixed examples - "event" should be added to function parameters.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/denis-aes/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit b128c48be3a5306b1045b18be21ee53ff8ebf4fc
Author: denis-aes <de...@gmail.com>
Date:   2014-04-08T14:45:10Z

    Update index.md
    
    Fixed examples - "event" should be added to function parameters.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: Update index.md

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: Update index.md

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/36#issuecomment-40851025
  
    Patch doesn't apply cleanly to dev branch (where all new code goes). Besides, it appears your change was already integrated in another patch:
    https://github.com/apache/cordova-plugin-inappbrowser/commit/9399ed39559d94c51567b226a8bf2cfb390de15c
    
    Because of that reason - please close this PR. Thank you for your contribution however! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---