FW: Question about SMTP AUTH and mozilla and apple mail

["Peter M. Goldstein" <pe...@yahoo.com>]

Noel,

There was already a thread on james-dev as a result of the bugzilla
modification (see emails of 7/2/02), but point taken.  Attached is the
diff.

This patch is designed to resolve bug #6340 in the least intrusive way -
by keeping the scope of the AUTH PLAIN specific argument parsing to
within the doAuth method.

--Peter 

-----Original Message-----
From: Noel J. Bergman [mailto:noel@devtech.com] 
Sent: Friday, July 26, 2002 6:34 PM
To: James Users List
Subject: RE: Question about SMTP AUTH and mozilla and apple mail

Excellent news!  :-)  Perhaps Peter can submit it a message to the JAMES
developer mailing list according to
http://jakarta.apache.org/site/bugs.html.  Then a few of us can look it
over, vet it, and encourage the maintainers to commit it.

[Yes, I know that the patch is in the bugs database, but the messsage
gives
us a place to hang the thread.]

	--- Noel

-----Original Message-----
From: David Rodal [mailto:iridiump@bellatlantic.net]
Sent: Friday, July 26, 2002 21:16
To: James Users List
Subject: Re: Question about SMTP AUTH and mozilla and apple mail


Yes Peter's fix works now for my OS X mail AND mozilla under OS X!!!!!

Check out the Peter's attachment for bug 6340 and put it in and you will
be very happy to!!!!

I'm the happiest man alive right now! :-)

David Rodal

Thanks again everyone.


On Friday, July 26, 2002, at 08:36 PM, eric aboudaram wrote:

> i have the same problem and i didn't find a solution
>
> mozilla send login@domain
> strange !!!!
>
> i create a user with logn@domain but whitout success
> :'(


--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>

RE: Question about SMTP AUTH and mozilla and apple mail

[Danny Angus <da...@apache.org>]

> (c) ideally in the code, but at least in e-mail, tell us what
> you're fixing
> and how the fix works, so that we can all review it.

Definitely in email, it is the only way we can realisticly collate patches
without having to work it out ourselves, if contributors mail them along
with a concise description of what, why and how.

d.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: Question about SMTP AUTH and mozilla and apple mail

["Noel J. Bergman" <no...@devtech.com>]

> There was already a thread on james-dev as a result of the bugzilla
> modification (see emails of 7/2/02), but point taken.  Attached is the
> diff.

> This patch is designed to resolve bug #6340 in the least intrusive way -
> by keeping the scope of the AUTH PLAIN specific argument parsing to
> within the doAuth method.

Critique:

1) Possibly my fault, but I only see the bugzilla report on 7/02/02.  No
actual discussion.

2) Attaching patches to bugzilla is not the recognized way to get them
accepted.

3) Danny already commented about patch format.

4) As far as I can see, your e-mail (above) has more information about what
the patch is, and how it works, than the patch.

The point is this: as Danny just admitted, he's been so busy with his
day-job that he hasn't even had time (for close to a month, at least, it
seems) to review contributions.  So if we agree that it is necessary for the
James developer community at large to help vet submissions, then we have to
help ourselves out by:

(a) submitting fixes in the documented format so that a committer can easily
apply them.
(b) make sure that patches are against the CVS head
(c) ideally in the code, but at least in e-mail, tell us what you're fixing
and how the fix works, so that we can all review it.

I firmly believe that each of these things contributes to smooth adoption of
patches.

People should read http://jakarta.apache.org/james/code-standards.html and
definitely http://jakarta.apache.org/site/contributing.html.

	--- Noel


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>