You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2012/08/02 07:28:55 UTC

svn commit: r1368354 - in /hbase/trunk: conf/hadoop-metrics.properties hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java

Author: tedyu
Date: Thu Aug  2 05:28:55 2012
New Revision: 1368354

URL: http://svn.apache.org/viewvc?rev=1368354&view=rev
Log:
HBASE-6399 MetricsContext should be different between RegionServerMetrics and RegionServerDynamicMetrics (Chunhui)


Modified:
    hbase/trunk/conf/hadoop-metrics.properties
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java

Modified: hbase/trunk/conf/hadoop-metrics.properties
URL: http://svn.apache.org/viewvc/hbase/trunk/conf/hadoop-metrics.properties?rev=1368354&r1=1368353&r2=1368354&view=diff
==============================================================================
--- hbase/trunk/conf/hadoop-metrics.properties (original)
+++ hbase/trunk/conf/hadoop-metrics.properties Thu Aug  2 05:28:55 2012
@@ -32,6 +32,24 @@ hbase.extendedperiod = 3600
 # hbase.period=10
 # hbase.servers=GMETADHOST_IP:8649
 
+# "hbase" context does basic metrics, "hbase-dynamic" context adds a bunch more and
+# would be expanded dynamically, but beware, enabling it may overwhelm your monitoring.
+
+# Configuration of the "hbase-dynamic" context for null
+hbase-dynamic.class=org.apache.hadoop.metrics.spi.NullContextWithUpdateThread
+hbase-dynamic.period=10
+
+# Configuration of the "hbase-dynamic" context for file
+# hbase-dynamic.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
+# hbase-dynamic.fileName=/tmp/metrics_hbase-dynamic.log
+
+# Configuration of the "hbase-dynamic" context for ganglia
+# Pick one: Ganglia 3.0 (former) or Ganglia 3.1 (latter)
+# hbase-dynamic.class=org.apache.hadoop.metrics.ganglia.GangliaContext
+# hbase-dynamic.class=org.apache.hadoop.metrics.ganglia.GangliaContext31
+# hbase-dynamic.period=10
+# hbase-dynamic.servers=GMETADHOST_IP:8649
+
 # Configuration of the "jvm" context for null
 jvm.class=org.apache.hadoop.metrics.spi.NullContextWithUpdateThread
 jvm.period=10

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java?rev=1368354&r1=1368353&r2=1368354&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerDynamicMetrics.java Thu Aug  2 05:28:55 2012
@@ -75,7 +75,7 @@ public class RegionServerDynamicMetrics 
   public final MetricsRegistry registry = new MetricsRegistry();
 
   private RegionServerDynamicMetrics() {
-    this.context = MetricsUtil.getContext("hbase");
+    this.context = MetricsUtil.getContext("hbase-dynamic");
     this.metricsRecord = MetricsUtil.createRecord(
                             this.context,
                             "RegionServerDynamicStatistics");