You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jesspav (via GitHub)" <gi...@apache.org> on 2025/11/21 00:31:12 UTC
[PR] Change aggregate function names [sedona-db]
jesspav opened a new pull request, #325:
URL: https://github.com/apache/sedona-db/pull/325
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(rust): Change aggregate function names [sedona-db]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #325:
URL: https://github.com/apache/sedona-db/pull/325#discussion_r2597445407
##########
rust/sedona-functions/src/st_analyze_agg.rs:
##########
@@ -41,40 +41,40 @@ use wkb::reader::Wkb;
use crate::executor::WkbExecutor;
-/// ST_Analyze_Aggr() aggregate UDF implementation
+/// ST_Analyze_Agg() aggregate UDF implementation
///
/// This function computes comprehensive statistics for a collection of geometries.
/// It returns a struct containing various metrics such as count, min/max coordinates,
/// mean size, and geometry type counts.
-pub fn st_analyze_aggr_udf() -> SedonaAggregateUDF {
+pub fn st_analyze_agg_udf() -> SedonaAggregateUDF {
SedonaAggregateUDF::new(
- "st_analyze_aggr",
- vec![Arc::new(STAnalyzeAggr {})],
+ "st_analyze_agg",
+ vec![Arc::new(STAnalyzeAgg {})],
Volatility::Immutable,
- Some(st_analyze_aggr_doc()),
+ Some(st_analyze_agg_doc()),
)
Review Comment:
agree. i guess this is fine. SedonaDB is pretty new so breaking changes might be ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(rust): Change aggregate function names [sedona-db]
Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on code in PR #325:
URL: https://github.com/apache/sedona-db/pull/325#discussion_r2596550801
##########
rust/sedona-functions/src/st_analyze_agg.rs:
##########
@@ -41,40 +41,40 @@ use wkb::reader::Wkb;
use crate::executor::WkbExecutor;
-/// ST_Analyze_Aggr() aggregate UDF implementation
+/// ST_Analyze_Agg() aggregate UDF implementation
///
/// This function computes comprehensive statistics for a collection of geometries.
/// It returns a struct containing various metrics such as count, min/max coordinates,
/// mean size, and geometry type counts.
-pub fn st_analyze_aggr_udf() -> SedonaAggregateUDF {
+pub fn st_analyze_agg_udf() -> SedonaAggregateUDF {
SedonaAggregateUDF::new(
- "st_analyze_aggr",
- vec![Arc::new(STAnalyzeAggr {})],
+ "st_analyze_agg",
+ vec![Arc::new(STAnalyzeAgg {})],
Volatility::Immutable,
- Some(st_analyze_aggr_doc()),
+ Some(st_analyze_agg_doc()),
)
Review Comment:
dang, i'm only just catching this right after the release... shouldn't we have maintained the old `_Aggr` suffix for backwards compatibility? Datafusion makes adding aliases easy for us. Would it still be worth re-introducing the old suffix for the following release, or nah?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(rust): Change aggregate function names [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #325:
URL: https://github.com/apache/sedona-db/pull/325#discussion_r2596926474
##########
rust/sedona-functions/src/st_analyze_agg.rs:
##########
@@ -41,40 +41,40 @@ use wkb::reader::Wkb;
use crate::executor::WkbExecutor;
-/// ST_Analyze_Aggr() aggregate UDF implementation
+/// ST_Analyze_Agg() aggregate UDF implementation
///
/// This function computes comprehensive statistics for a collection of geometries.
/// It returns a struct containing various metrics such as count, min/max coordinates,
/// mean size, and geometry type counts.
-pub fn st_analyze_aggr_udf() -> SedonaAggregateUDF {
+pub fn st_analyze_agg_udf() -> SedonaAggregateUDF {
SedonaAggregateUDF::new(
- "st_analyze_aggr",
- vec![Arc::new(STAnalyzeAggr {})],
+ "st_analyze_agg",
+ vec![Arc::new(STAnalyzeAgg {})],
Volatility::Immutable,
- Some(st_analyze_aggr_doc()),
+ Some(st_analyze_agg_doc()),
)
Review Comment:
That's a great point...I'm comfortable waiting to see if anybody complains 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(rust): Change aggregate function names [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #325:
URL: https://github.com/apache/sedona-db/pull/325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org