You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/10 02:41:03 UTC
[GitHub] [dolphinscheduler] geosmart opened a new issue #5788: [Improvement][Resource] resource updateResource should check user permission
geosmart opened a new issue #5788:
URL: https://github.com/apache/dolphinscheduler/issues/5788
in dolphinscheduler
api ,we can update resource with 2 way:
1. `updateResource`：replace the file
2. `updateResourceContent`：update the file content
but in the [ResourceService.java](https://github.com/apache/dolphinscheduler/blob/e628e4e8fdc72f0362449a78870493789450b284/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java#L287)
`updateResource` do check the user perm
```java
if (!hasPerm(loginUser, resource.getUserId())) {
putMsg(result, Status.USER_NO_OPERATION_PERM);
return result;
}
```
and `updateResourceContent` does not check the permission
why? is it a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5788: [Improvement][Resource] resource updateResource should check user permission
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5788:
URL: https://github.com/apache/dolphinscheduler/issues/5788#issuecomment-877543277
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org