You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/05 15:37:06 UTC
Review Request 28748: CLOUDSTACK-8021: Change test cases to use host
information from configurableData section in test_data.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8021
https://issues.apache.org/jira/browse/CLOUDSTACK-8021
Repository: cloudstack-git
Description
-------
Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py
Also fixed few pep8 issues.
Diffs
-----
test/integration/component/test_deploy_vgpu_vm.py 0284eab
test/integration/component/test_persistent_networks.py 4b1bc7a
test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92
Diff: https://reviews.apache.org/r/28748/diff/
Testing
-------
Tested test_persistent_networks.py
Other test cases not testable right now. Change is only in reading the config value.
Thanks,
Gaurav Aradhye
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use
host information from configurableData section in test_data.py
Posted by Rajani Karuturi <ra...@apache.org>.
> On Dec. 11, 2014, 12:17 p.m., SrikanteswaraRao Talluri wrote:
> > doesn't apply cleanly on 4.5
> >
> > git am -s /Users/talluri/Downloads/0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
> > Applying: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
> > error: patch failed: test/integration/component/test_deploy_vgpu_vm.py:15
> > error: test/integration/component/test_deploy_vgpu_vm.py: patch does not apply
> > Patch failed at 0001 CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
> > The copy of the patch that failed is found in:
> > /Users/talluri/asf/cloudstack/.git/rebase-apply/patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am --abort".
Talluri,
try using git am -3. It might resolve.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/#review64718
-----------------------------------------------------------
On Dec. 5, 2014, 2:37 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28748/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:37 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8021
> https://issues.apache.org/jira/browse/CLOUDSTACK-8021
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py
>
> Also fixed few pep8 issues.
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py 0284eab
> test/integration/component/test_persistent_networks.py 4b1bc7a
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92
>
> Diff: https://reviews.apache.org/r/28748/diff/
>
>
> Testing
> -------
>
> Tested test_persistent_networks.py
> Other test cases not testable right now. Change is only in reading the config value.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use
host information from configurableData section in test_data.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/#review64718
-----------------------------------------------------------
doesn't apply cleanly on 4.5
git am -s /Users/talluri/Downloads/0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
Applying: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
error: patch failed: test/integration/component/test_deploy_vgpu_vm.py:15
error: test/integration/component/test_deploy_vgpu_vm.py: patch does not apply
Patch failed at 0001 CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
The copy of the patch that failed is found in:
/Users/talluri/asf/cloudstack/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
- SrikanteswaraRao Talluri
On Dec. 5, 2014, 2:37 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28748/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:37 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8021
> https://issues.apache.org/jira/browse/CLOUDSTACK-8021
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py
>
> Also fixed few pep8 issues.
>
>
> Diffs
> -----
>
> test/integration/component/test_deploy_vgpu_vm.py 0284eab
> test/integration/component/test_persistent_networks.py 4b1bc7a
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92
>
> Diff: https://reviews.apache.org/r/28748/diff/
>
>
> Testing
> -------
>
> Tested test_persistent_networks.py
> Other test cases not testable right now. Change is only in reading the config value.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use
host information from configurableData section in test_data.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 11:41 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8021
https://issues.apache.org/jira/browse/CLOUDSTACK-8021
Repository: cloudstack-git
Description
-------
Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py
Also fixed few pep8 issues.
Diffs
-----
test/integration/component/test_deploy_vgpu_vm.py 0284eab
test/integration/component/test_persistent_networks.py 4b1bc7a
test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92
Diff: https://reviews.apache.org/r/28748/diff/
Testing
-------
Tested test_persistent_networks.py
Other test cases not testable right now. Change is only in reading the config value.
File Attachments (updated)
----------------
Patch for 4.5
https://reviews.apache.org/media/uploaded/files/2014/12/16/3251644a-f44e-49b1-af90-78a10492cd71__0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
Thanks,
Gaurav Aradhye
Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use
host information from configurableData section in test_data.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/
-----------------------------------------------------------
(Updated Dec. 12, 2014, 12:55 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Changes
-------
Added rebased patch for 4.5
Bugs: CLOUDSTACK-8021
https://issues.apache.org/jira/browse/CLOUDSTACK-8021
Repository: cloudstack-git
Description
-------
Changing few test cases to use the host username, password from the configurableData section in test_data.py. Earlier they were reading the hard coded value. Removed old host_password value from test_data.py
Also fixed few pep8 issues.
Diffs
-----
test/integration/component/test_deploy_vgpu_vm.py 0284eab
test/integration/component/test_persistent_networks.py 4b1bc7a
test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92
Diff: https://reviews.apache.org/r/28748/diff/
Testing
-------
Tested test_persistent_networks.py
Other test cases not testable right now. Change is only in reading the config value.
File Attachments (updated)
----------------
0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
https://reviews.apache.org/media/uploaded/files/2014/12/12/c34be7cc-b1f2-4f6e-8146-1788f7070d6c__0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
Thanks,
Gaurav Aradhye