You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2012/02/13 17:54:13 UTC
svn commit: r1243608 -
/myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Author: lu4242
Date: Mon Feb 13 16:54:12 2012
New Revision: 1243608
URL: http://svn.apache.org/viewvc?rev=1243608&view=rev
Log:
MYFACES-3461 HtmlRendererUtils.renderSelectOptions() performs many unnecessary calls to View Bean
Modified:
myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Modified: myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java?rev=1243608&r1=1243607&r2=1243608&view=diff
==============================================================================
--- myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/core/branches/2.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java Mon Feb 13 16:54:12 2012
@@ -540,6 +540,8 @@ public final class HtmlRendererUtils
ResponseWriter writer = context.getResponseWriter();
// check for the hideNoSelectionOption attribute
boolean hideNoSelectionOption = isHideNoSelectionOption(component);
+ boolean componentDisabled = isTrue(component.getAttributes()
+ .get("disabled"));
for (Iterator it = selectItemList.iterator(); it.hasNext();)
{
@@ -601,8 +603,6 @@ public final class HtmlRendererUtils
}
String labelClass = null;
- boolean componentDisabled = isTrue(component.getAttributes()
- .get("disabled"));
if (componentDisabled || disabled)
{