You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/07/13 23:28:12 UTC
[GitHub] lizhanhui commented on a change in pull request #358: [ISSUE #292]
Add support of transactional message feature
lizhanhui commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature
URL: https://github.com/apache/rocketmq/pull/358#discussion_r202494199
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
##########
@@ -142,6 +150,9 @@
private BrokerFastFailure brokerFastFailure;
private Configuration configuration;
private FileWatchService fileWatchService;
+ private TransactionalMessageCheckService transactionMsgCheckService;
Review comment:
Please use consistent naming. If abbreviation were used, so were these relevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services