You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Csaba Palfi <no...@github.com> on 2015/07/15 15:27:04 UTC
[jclouds-labs] Use docker cacert in SSLContext (#190)
#187 automates managing the local cacert keystore but when you deploy to production-like environments you might not want to mess with that and simply use a custom SSLContext which knows about the docker cacert.
TODO: making sure this works even if you specify `jclouds.trust-all-certs=true`
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/190
-- Commit Summary --
* [docker] use docker cacert in SSL context
-- File Changes --
M docker/pom.xml (2)
M docker/src/main/java/org/jclouds/docker/DockerApiMetadata.java (3)
M docker/src/main/java/org/jclouds/docker/suppliers/SSLContextWithKeysSupplier.java (35)
M docker/src/test/java/org/jclouds/docker/compute/BaseDockerApiLiveTest.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/190.patch
https://github.com/jclouds/jclouds-labs/pull/190.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Csaba Palfi <no...@github.com>.
Closed #190.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190#event-357602451
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Csaba Palfi <no...@github.com>.
> @@ -113,8 +128,8 @@ private static PrivateKey getKey(String privateKey) {
> }
> }
>
> - private static String loadFile(final String filePath) throws IOException {
> - return Files.toString(new File(filePath), Charsets.UTF_8);
> + private static String loadFile(final String filePath) throws IOException{
> + return Files.toString(new File(filePath), Charsets.UTF_8);
Fixing on `feature/docker-1.7`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190/files#r34796377
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Andrew Donald Kennedy <no...@github.com>.
> this.creds = creds;
> + this.trustManager = !isNullOrEmpty(caCertPath) ? getTrustManagerWithCaCert(caCertPath) : null;
Should we keep the original logic (to optionally use `TrustAllCerts`) if no CA certificate is supplied?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190/files#r34784985
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Csaba Palfi <no...@github.com>.
Now part of #188
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190#issuecomment-121977624
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Csaba Palfi <no...@github.com>.
> this.creds = creds;
> + this.trustManager = !isNullOrEmpty(caCertPath) ? getTrustManagerWithCaCert(caCertPath) : null;
Fixing on `feature/docker-1.7`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190/files#r34796383
Re: [jclouds-labs] Use docker cacert in SSLContext (#190)
Posted by Andrew Donald Kennedy <no...@github.com>.
> @@ -113,8 +128,8 @@ private static PrivateKey getKey(String privateKey) {
> }
> }
>
> - private static String loadFile(final String filePath) throws IOException {
> - return Files.toString(new File(filePath), Charsets.UTF_8);
> + private static String loadFile(final String filePath) throws IOException{
> + return Files.toString(new File(filePath), Charsets.UTF_8);
Spacing is off here, I think
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/190/files#r34785079