[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #395: [FLINK-30125] Projection pushdown is not work for partial update

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #395:
URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030043673


##########
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/PartialUpdateITCase.java:
##########
@@ -65,8 +65,10 @@ public void testMergeRead() {
         batchSql("INSERT INTO T VALUES (1, 2, 4, 5, CAST(NULL AS STRING))");
         batchSql("INSERT INTO T VALUES (1, 2, 4, CAST(NULL AS INT), '6')");
 
-        List<Row> result = batchSql("SELECT * FROM T");
-        assertThat(result).containsExactlyInAnyOrder(Row.of(1, 2, 4, 5, "6"));
+        assertThat(batchSql("SELECT * FROM T")).containsExactlyInAnyOrder(Row.of(1, 2, 4, 5, "6"));
+
+        // projection
+        assertThat(batchSql("SELECT a FROM T")).containsExactlyInAnyOrder(Row.of(4));

Review Comment:
   Does this cover the array and list projection?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org