[GitHub] [shardingsphere] abhinav-koppula commented on a diff in pull request #20796: [Issue #20377]-Improved coverage for AlterIndexStatementHandler

[GitBox <gi...@apache.org>]

abhinav-koppula commented on code in PR #20796:
URL: https://github.com/apache/shardingsphere/pull/20796#discussion_r962661058


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandlerTest.java:
##########
@@ -62,4 +66,28 @@ public void assertGetRenameIndexSegmentWithoutRenameIndexSegmentForPostgreSQL()
         Optional<IndexSegment> indexSegment = AlterIndexStatementHandler.getRenameIndexSegment(alterIndexStatement);
         assertFalse(indexSegment.isPresent());
     }
+
+    @Test
+    public void assertGetRenameIndexSegmentForOpenGauss() {
+        IndexSegment indexSegment = new IndexSegment(0, 0, new IndexNameSegment(0, 0, new IdentifierValue("")));
+        OpenGaussAlterIndexStatement alterIndexStatement = new OpenGaussAlterIndexStatement();
+        alterIndexStatement.setRenameIndex(indexSegment);
+        Optional<IndexSegment> actual = AlterIndexStatementHandler.getRenameIndexSegment(alterIndexStatement);
+        assertTrue(actual.isPresent());
+        assertThat(actual.get(), is(indexSegment));
+    }
+
+    @Test
+    public void assertGetSimpleTableSegmentForOtherDatabases() {
+        assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new OpenGaussAlterIndexStatement()).isPresent());
+        assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new OracleAlterIndexStatement()).isPresent());
+        assertFalse(AlterIndexStatementHandler.getSimpleTableSegment(new PostgreSQLAlterIndexStatement()).isPresent());
+    }
+
+    @Test
+    public void assertGetRenameIndexSegmentForOtherDatabases() {
+        assertFalse(AlterIndexStatementHandler.getRenameIndexSegment(new OracleAlterIndexStatement()).isPresent());
+        assertFalse(AlterIndexStatementHandler.getRenameIndexSegment(new SQLServerAlterIndexStatement()).isPresent());
+    }
+

Review Comment:
   Removed blank line. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org