You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by lcqzte10192193 <gi...@git.apache.org> on 2018/11/27 11:47:06 UTC

[GitHub] spark pull request #23154: [SQL] Correct two exception message in Unresolved...

GitHub user lcqzte10192193 opened a pull request:

    https://github.com/apache/spark/pull/23154

    [SQL] Correct two exception message in UnresolvedGenerator class

    ## What changes were proposed in this pull request?
    
    UnresolvedGenerator  don't support doGenCode and terminate method,but  exception messages are not the same with method name.This PR correct these messages.
    
    ## How was this patch tested?
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lcqzte10192193/spark wid-lcq-1127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23154
    
----
commit 1de8146194c5542ad5c2f3d2644d4c5ab6951853
Author: lichaoqun <li...@...>
Date:   2018-11-27T11:28:08Z

    [SQL] Correct two exception message in UnresolvedGenerator class

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

Posted by 10110346 <gi...@git.apache.org>.

Github user 10110346 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23154#discussion_r236920634
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ---
    @@ -510,42 +510,42 @@ public void readIntegers(int total, WritableColumnVector c, int rowId) {
     
       @Override
       public byte readByte() {
    -    throw new UnsupportedOperationException("only readInts is valid.");
    +    throw new UnsupportedOperationException("only readByte is valid.");
    --- End diff --
    
    These exception messages seem to be correct ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

Posted by lcqzte10192193 <gi...@git.apache.org>.

Github user lcqzte10192193 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23154#discussion_r236923346
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java ---
    @@ -510,42 +510,42 @@ public void readIntegers(int total, WritableColumnVector c, int rowId) {
     
       @Override
       public byte readByte() {
    -    throw new UnsupportedOperationException("only readInts is valid.");
    +    throw new UnsupportedOperationException("only readByte is valid.");
    --- End diff --
    
    ok, thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23154: [SQL] Correct two exception message in UnresolvedGenerat...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23154
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23154: [SPARK-26195][SQL] Correct exception messages in some cl...

Posted by lcqzte10192193 <gi...@git.apache.org>.

Github user lcqzte10192193 commented on the issue:

    https://github.com/apache/spark/pull/23154
  
    > Good catch. I believe other files (e.g. `VectorizedRleValuesReader.java`, `Expression.scala`, and `generators.scala` also have the similar problem. Can this PR address them?
    ···
    
    
    > Good catch. I believe other files (e.g. `VectorizedRleValuesReader.java`, `Expression.scala`, and `generators.scala` also have the similar problem. Can this PR address them?
    
    ok，I will fix them，thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

Posted by lcqzte10192193 <gi...@git.apache.org>.

Github user lcqzte10192193 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23154#discussion_r236923308
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ---
    @@ -204,10 +204,10 @@ case class UnresolvedGenerator(name: FunctionIdentifier, children: Seq[Expressio
         throw new UnsupportedOperationException(s"Cannot evaluate expression: $this")
     
       override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode =
    -    throw new UnsupportedOperationException(s"Cannot evaluate expression: $this")
    +    throw new UnsupportedOperationException(s"Cannot generate code expression: $this")
    --- End diff --
    
    Yes,I fix them.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23154: [SPARK-26195][SQL] Correct exception messages in some cl...

Posted by 10110346 <gi...@git.apache.org>.

Github user 10110346 commented on the issue:

    https://github.com/apache/spark/pull/23154
  
    LGTM,thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23154: [SQL] Correct two exception message in UnresolvedGenerat...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23154
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23154: [SPARK-26195][SQL] Correct exception messages in some cl...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/23154
  
    thanks, merging to master!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org