You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/10 08:33:05 UTC

[GitHub] [avro] milenkovicm opened a new pull request, #1817: AVRO-3600: UnionSchema::new method should be public

milenkovicm opened a new pull request, #1817:
URL: https://github.com/apache/avro/pull/1817

   UnionSchema::new method should be public to facility programmatic schema
   creation. Visibility of the method changed.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: trivial change of method visibility 
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1817: AVRO-3600: UnionSchema::new method should be public

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1817:
URL: https://github.com/apache/avro/pull/1817#issuecomment-1210370529

   Thanks for the PR! 
   I agree that this is a good improvement!
   
   But why did you say: 
   
   > Visibility of the method changed.
   
   https://github.com/flavray/avro-rs/blob/main/src/schema.rs#L326 shows that it was crate private even in the old version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #1817: AVRO-3600: UnionSchema::new method should be public

Posted by GitBox <gi...@apache.org>.
martin-g merged PR #1817:
URL: https://github.com/apache/avro/pull/1817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] milenkovicm commented on pull request #1817: AVRO-3600: UnionSchema::new method should be public

Posted by GitBox <gi...@apache.org>.
milenkovicm commented on PR #1817:
URL: https://github.com/apache/avro/pull/1817#issuecomment-1210374562

   > Visibility of the method changed.
   
   Sorry for confusion, what I meant I've changed it to public. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1817: AVRO-3600: UnionSchema::new method should be public

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1817:
URL: https://github.com/apache/avro/pull/1817#issuecomment-1210402328

   Thank you for the contribution, @milenkovicm !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org