You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/03 18:29:21 UTC
Re: Review Request 68176: Fixed gRPC build for CMake with
multi-configuration generators.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68176/
-----------------------------------------------------------
(Updated Aug. 3, 2018, 6:29 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
Changes
-------
Addressed Benjamin's comment.
Summary (updated)
-----------------
Fixed gRPC build for CMake with multi-configuration generators.
Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395
Repository: mesos
Description (updated)
-------
This patch adds `--config` options to the CMake build commands for gRPC,
so that when building with a multi-configuration generator (e.g., Visual
Studio or XCode), it could pass the specified configuration along.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916
Diff: https://reviews.apache.org/r/68176/diff/2/
Changes: https://reviews.apache.org/r/68176/diff/1-2/
Testing
-------
Built and tested using VS on Windows
Built and tested using VS on Windows with `--config Release`
Built and tested using Ninja on Linux
Built and tested using Makefile on Linux
Thanks,
Chun-Hung Hsiao