You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/08/05 11:11:31 UTC
[I] Improve performance of `GeometricMean` aggregage: implement `convert_to_state` [datafusion]
alamb opened a new issue, #11816:
URL: https://github.com/apache/datafusion/issues/11816
### Is your feature request related to a problem or challenge?
@korowa added "skip partial aggregation mode" in https://github.com/apache/datafusion/pull/11627 which helps with high cardinality aggregates by doing minimal work for the first phase of the aggregation. This mode is triggered dynamically based on how effective the first aggregation phase is working.
In order to use this new mode, the corresponding `GroupsAccumulator` needs to implement the `convert_to_state` method
https://github.com/apache/datafusion/blob/c340b6ab7a2875c6924f825782f0c5ea408aff3d/datafusion/expr/src/groups_accumulator.rs#L166-L213
### Describe the solution you'd like
Implement `covert_to_state` for
https://github.com/apache/datafusion/blob/2f02c43b6283472c7c620c68819050128a7e8544/datafusion-examples/examples/advanced_udaf.rs#L269-L268
Add tests in https://github.com/apache/datafusion/blob/c340b6ab7a2875c6924f825782f0c5ea408aff3d/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt#L18-L19
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Improve performance of `Avg` aggregage: implement `convert_to_state` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11816:
URL: https://github.com/apache/datafusion/issues/11816#issuecomment-2268818210
I have a draft PR for this here: https://github.com/apache/datafusion/pull/11734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Improve performance of `Avg` aggregate: implement `convert_to_state` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #11816: Improve performance of `Avg` aggregate: implement `convert_to_state`
URL: https://github.com/apache/datafusion/issues/11816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org