You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2015/02/25 23:36:19 UTC
[GitHub] trafficserver pull request: TS-3370: header_rewrite plugin uses de...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/173
TS-3370: header_rewrite plugin uses dead continuation.
I have see this in production. As far as I can tell the problem is that the remap rules can be reloaded, leading to creating new continuations to service those rules. 60 seconds later the old continuations are deleted. If anything is pending long enough it can still use an old (dead) continuation.
This change reference counts the config / continuation set and destroys the old continuations when the last reference is dropped. Note that we can't use the standard config registration mechanism because this is structured to have a config instance per remap rule which would overwhelm that mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-3370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 43d671b8e6bcdeee22ba795511e6e2de471b42a2
Author: Alan M. Carroll <am...@apache.org>
Date: 2015-02-25T22:27:56Z
TS-3370: header_rewrite plugin uses dead continuation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3370: header_rewrite plugin uses de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---