You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Danny Chan (JIRA)" <ji...@apache.org> on 2019/07/10 06:00:00 UTC

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

    [ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881752#comment-16881752 ] 

Danny Chan commented on CALCITE-3187:
-------------------------------------

The `SqlReturnTypeInference DECIMAL_SUM` itself is designed to be pluggable, and it is used to infer return types of many operators, so why we need another way (the type factory) for overriding the inferring logic ? Shouldn't we define another `SqlReturnTypeInference` and use it where we want ?

> Derive all decimal return type through type factory
> ---------------------------------------------------
>
>                 Key: CALCITE-3187
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3187
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Praveen Kumar Desabandu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently decimal product and quotient return types are derived through type factory, this allows clients to override the return type if they so desire.
> But decimal sum is embedded in return types, also decimal mod does not have a return type inference defined.
> This task is to derive all of the return types through type factory, so that clients can override if they wish to.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)