You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com> on 2017/04/07 15:07:40 UTC
Review Request 58264: hive maybe not rely on slider
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20710
https://issues.apache.org/jira/browse/AMBARI-20710
Repository: ambari
Description
-------
when adding the hive, the dialog tips that
"
You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
"
There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
Diff: https://reviews.apache.org/r/58264/diff/1/
Testing
-------
done it
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 58264: hive maybe not rely on slider
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 10, 2017, 5:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml
> > Line 495 (original)
> > <https://reviews.apache.org/r/58264/diff/1/?file=1686482#file1686482line495>
> >
> > Let's also make the same change for Hive 3.0
I mean under common-services/HIVE/3.0.0.3.0
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review171445
-----------------------------------------------------------
On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 1:05 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review171445
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml
Line 495 (original)
<https://reviews.apache.org/r/58264/#comment244383>
Let's also make the same change for Hive 3.0
- Alejandro Fernandez
On April 7, 2017, 3:07 p.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 3:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review172963
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml
Line 495 (original)
<https://reviews.apache.org/r/58264/#comment245997>
-1
Right now HDP 3.0 in its current form does require Slider for LLAP.
- Alejandro Fernandez
On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 1:05 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 11, 2017, 2:51 a.m., Jaimin Jetly wrote:
> > Enabling interactive query for Hive which installs HiveServer2 interactive host component and deploys LLAP requires slider service.
> > That's the reason for slider being as a dependency for Hive.
> >
> > I doubt hive service check will pass if on installer wizard hive is selected without slider service and interactive query settings are enabled on "customize services" page for hive
> >
> >
> > Reference: https://cwiki.apache.org/confluence/display/Hive/LLAP
yes,you're right. Even not installed slider, hive service check still pass.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review171514
-----------------------------------------------------------
On \u56db\u6708 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 11, 2017, 1:05 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by Jaimin Jetly <ja...@hortonworks.com>.
> On April 11, 2017, 2:51 a.m., Jaimin Jetly wrote:
> > Enabling interactive query for Hive which installs HiveServer2 interactive host component and deploys LLAP requires slider service.
> > That's the reason for slider being as a dependency for Hive.
> >
> > I doubt hive service check will pass if on installer wizard hive is selected without slider service and interactive query settings are enabled on "customize services" page for hive
> >
> >
> > Reference: https://cwiki.apache.org/confluence/display/Hive/LLAP
>
> zhangxiaolu zhangxiaolu wrote:
> yes,you're right. Even not installed slider, hive service check still pass.
I mean slider is required by hive service as of now.
If not installed then hive interactive query will not work.
- Jaimin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review171514
-----------------------------------------------------------
On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 1:05 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review171514
-----------------------------------------------------------
Enabling interactive query for Hive which installs HiveServer2 interactive host component and deploys LLAP requires slider service.
That's the reason for slider being as a dependency for Hive.
I doubt hive service check will pass if on installer wizard hive is selected without slider service and interactive query settings are enabled on "customize services" page for hive
Reference: https://cwiki.apache.org/confluence/display/Hive/LLAP
- Jaimin Jetly
On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 1:05 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/#review172920
-----------------------------------------------------------
What is the status of this review? It seems Slider is needed for Hive LLAP so the dependency must still be there.
- Nate Cole
On April 10, 2017, 9:05 p.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58264/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 9:05 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20710
> https://issues.apache.org/jira/browse/AMBARI-20710
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when adding the hive, the dialog tips that
> "
> You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
> "
> There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
>
>
> Diff: https://reviews.apache.org/r/58264/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> File Attachments
> ----------------
>
> AMBARI-20710.patch
> https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58264: hive maybe not rely on slider
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58264/
-----------------------------------------------------------
(Updated \u56db\u6708 11, 2017, 1:05 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20710
https://issues.apache.org/jira/browse/AMBARI-20710
Repository: ambari
Description
-------
when adding the hive, the dialog tips that
"
You did not select Slider, but it is needed by other services you selected. We will automatically add Slider. Is this OK?
"
There is no dependency relationship between hive and slider,so maybe we should remove requiceservice slider in hive's metainfo.xml
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 6d9098f
Diff: https://reviews.apache.org/r/58264/diff/1/
Testing
-------
done it
File Attachments (updated)
----------------
AMBARI-20710.patch
https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch
Thanks,
zhangxiaolu zhangxiaolu