[GitHub] [netbeans] junichi11 commented on issue #1317: [NETBEANS-1696] PHP 7.4 Support

[GitBox <gi...@apache.org>]

junichi11 commented on issue #1317: [NETBEANS-1696] PHP 7.4 Support
URL: https://github.com/apache/netbeans/pull/1317#issuecomment-504980533
 
 
   > What you mean exactly?
   
   It means that `__serialize()` and `__unserialize()` are always available although they are available since PHP 7.4. i.e. The two methods are added without checking the PhpVersion.
   
   https://github.com/apache/netbeans/blob/71b02dbfeabb0db923400cab33d5ef1d3c740dba/php/php.editor/src/org/netbeans/modules/php/editor/elements/MethodElementImpl.java#L95-L98
   
   
   > Maybe try to add test for e.g. `11_22` (`Use cases to avoid` in [docs](https://wiki.php.net/rfc/numeric_literal_separator))? If I understand it correctly, it is valid (it should be avoided but still, it is not a syntax error). Am I right? 
   
   It means this, right?
   ```php
   // don't do this:
   $phoneNumber = 345_6789;
   $creditCard = 231_6547_9081_2543;
   $socialSecurity = 111_11_1111;
   ```
   Yes, you are right. These numbers are not syntax errors.
   I'll add numbers added the separator(_) randomly to the test file later.
   e.g. 
   ```php
   12345_6_7_89_0;
   1_23_456_7_89.8_8_888_88;
   0x1_234_ABCD;
   0b0_1_0111_11;
   012_3_456;
   ```
   Thanks for the heads up :) Maybe, I'll push tomorrow.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists