[GitHub] [solr] madrob commented on a diff in pull request #872: SOLR-16204: Update lucene dependency version to 9.1.0

[GitBox <gi...@apache.org>]

madrob commented on code in PR #872:
URL: https://github.com/apache/solr/pull/872#discussion_r878283318


##########
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##########
@@ -109,20 +109,20 @@ and the hyper-parameter of the HNSW algorithm make sure you set this configurati
 Here's how `DenseVectorField` can be configured with the advanced codec hyper-parameters:
 
 [source,xml]
-<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" similarityFunction="cosine" codecFormat="Lucene90HnswVectorsFormat" hnswMaxConnections="10" hnswBeamWidth="40"/>
+<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" similarityFunction="cosine" codecFormat="Lucene91HnswVectorsFormat" hnswMaxConnections="10" hnswBeamWidth="40"/>
 <field name="vector" type="knn_vector" indexed="true" stored="true"/>
 
 `codecFormat`::
 +
 [%autowidth,frame=none]
 |===
-|Optional |Default: `Lucene90HnswVectorsFormat`
+|Optional |Default: `Lucene91HnswVectorsFormat`
 |===
 +
 (advanced) Specifies the knn codec implementation to use
 +
 
-Accepted values: `Lucene90HnswVectorsFormat`.
+Accepted values: `Lucene91HnswVectorsFormat`.

Review Comment:
   Should we be able to accept the Lucene90HnswVectorsFormat here as well? I'm not an expert on this, but from reading LUCENE-10054 it looks like this format is not entirely compatible with the old one... Should we give users the option to stay on the same format?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org