You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/15 21:32:27 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10895: chore: add eslint-import-resolver-typescript
ktmud opened a new pull request #10895:
URL: https://github.com/apache/incubator-superset/pull/10895
### SUMMARY
Add [eslint-import-resolver-typescript](https://www.npmjs.com/package/eslint-import-resolver-typescript), let ESLint understand tsconfig.json when importing modules, so we can use `compilerOption.paths` to override TS modules.
Also disabled an unrelated type warning while testing.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Our custom Superset installation has following `tsconfig.json` override:
```js
{
"compilerOptions": {
"allowJs": true,
"allowSyntheticDefaultImports": true,
"baseUrl": ".",
"paths": {
"src/*": [
"./src/*",
"../../../incubator-superset/superset-frontend/src/*"
],
},
...
```
This change shall allow ESLint to understand the imports when files are not available in `incubator-superset`.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10895: chore: add eslint-import-resolver-typescript
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10895:
URL: https://github.com/apache/incubator-superset/pull/10895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org