You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jayendra Parab <ja...@gmail.com> on 2021/04/01 06:45:45 UTC
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be
configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222759
-----------------------------------------------------------
distro/src/bin/atlas_config.py
Lines 741 (patched)
<https://reviews.apache.org/r/73249/#comment311937>
Remove this print msg...
distro/src/bin/atlas_start.py
Lines 29 (patched)
<https://reviews.apache.org/r/73249/#comment311936>
We should have these constants in atlas_config.py and should be names as VERTEX_INDEX_NAME_CONF
The method which gets the name, should make use of these constants from there
distro/src/conf/atlas-application.properties
Lines 83 (patched)
<https://reviews.apache.org/r/73249/#comment311935>
Kee the default index names as vertex_index, edge_index, fulltext_index
- Jayendra Parab
On March 30, 2021, 10:41 a.m., chaitali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> -----------------------------------------------------------
>
> (Updated March 30, 2021, 10:41 a.m.)
>
>
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
>
>
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently in Atlas, the collection names are not configurable
>
> We need to provide functionality where in names of the solr collections can be customized using property configuration
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75
> distro/src/bin/atlas_config.py 80b3bfb78
> distro/src/bin/atlas_start.py 7cf35a92a
> distro/src/conf/atlas-application.properties e06e74a26
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a
>
>
> Diff: https://reviews.apache.org/r/73249/diff/2/
>
>
> Testing
> -------
>
> mvn clean install
> atlas server up and running
> Collections created with entities linked
>
>
> Thanks,
>
> chaitali
>
>