You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/01/31 08:21:43 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2988: [Enhancement] String values are compared using '==', not 'equals()'

Alonexc opened a new issue, #2988:
URL: https://github.com/apache/incubator-eventmesh/issues/2988

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/215705806-fb2833d1-bc6b-4a7c-a6da-ae78229966c0.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ProducerGroupConf.java line 51
   
   
   ### Describe the solution you'd like
   
   reference:
   ![image](https://user-images.githubusercontent.com/91315508/215705846-ab7b1de8-d387-4b1b-879e-54c8aa240b52.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] Alonexc commented on issue #2988: [Enhancement] String values are compared using '==', not 'equals()'

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #2988:
URL: https://github.com/apache/incubator-eventmesh/issues/2988#issuecomment-1411237916

   > @Alonexc Hi ! i would do this, is it have to be done in entire codebase or just in ProducerGroupConf ?
   
   Welcome, just do it in this class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] Alonexc closed issue #2988: [Enhancement] String values are compared using '==', not 'equals()'

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #2988: [Enhancement] String values are compared using '==', not 'equals()'
URL: https://github.com/apache/incubator-eventmesh/issues/2988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] kanha-gupta commented on issue #2988: [Enhancement] String values are compared using '==', not 'equals()'

Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on issue #2988:
URL: https://github.com/apache/incubator-eventmesh/issues/2988#issuecomment-1411160550

   @Alonexc Hi ! i would do this,
   is it have to be done in entire codebase or just in ProducerGroupConf ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org