[GitHub] [tvm] driazati commented on a diff in pull request #13012: [tir] Add line level debug info

[GitBox <gi...@apache.org>]

driazati commented on code in PR #13012:
URL: https://github.com/apache/tvm/pull/13012#discussion_r1026803110


##########
src/printer/tir_text_printer.cc:
##########
@@ -149,26 +149,28 @@ Doc TIRTextPrinter::PrintPrimFunc(const PrimFunc& prim_func) {
       buffer_map_doc.push_back(Print(v) << ": " << Print(buf));
     }
     doc << Doc::Indent(
-        2, Doc::NewLine() << "buffer_map = {" << PrintSep(buffer_map_doc, Doc::Text(", ")) << "}");
+        2, NewLine() << "buffer_map = {" << PrintSep(buffer_map_doc, Doc::Text(", ")) << "}");

Review Comment:
   This calls `virtual TIRTextPrinter::NewLine` instead of `Doc::NewLine` so the debug text printer can flush the buffer of statements, so really there should be no direct `Doc::NewLine` calls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org