You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2017/12/09 21:27:43 UTC
[3/5] ant git commit: length tests are redundant with content
assertions
length tests are redundant with content assertions
Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/ca1ed226
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/ca1ed226
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/ca1ed226
Branch: refs/heads/master
Commit: ca1ed226f7814aadc67db6a63970fb10f1e45517
Parents: bd676a5
Author: Stefan Bodewig <bo...@apache.org>
Authored: Sat Dec 9 22:00:36 2017 +0100
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Sat Dec 9 22:00:36 2017 +0100
----------------------------------------------------------------------
src/tests/junit/org/apache/tools/mail/MailMessageTest.java | 8 --------
1 file changed, 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ant/blob/ca1ed226/src/tests/junit/org/apache/tools/mail/MailMessageTest.java
----------------------------------------------------------------------
diff --git a/src/tests/junit/org/apache/tools/mail/MailMessageTest.java b/src/tests/junit/org/apache/tools/mail/MailMessageTest.java
index fa95b7b..9a1aa8c 100644
--- a/src/tests/junit/org/apache/tools/mail/MailMessageTest.java
+++ b/src/tests/junit/org/apache/tools/mail/MailMessageTest.java
@@ -120,7 +120,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result); // order of headers cannot be guaranteed
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -172,7 +171,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result); // order of headers cannot be guaranteed
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -225,7 +223,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result);
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -277,7 +274,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result);
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -329,7 +325,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result);
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -380,7 +375,6 @@ public class MailMessageTest {
"250\r\n" +
"QUIT\r\n" +
"221\r\n";
- assertEquals(expectedResult.length(), result.length());
assertEquals(expectedResult, result);
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());
}
@@ -441,8 +435,6 @@ public class MailMessageTest {
bos1.print(expectedResult);
bos2.print(result);
- assertEquals("expected message length != actual message length "
- + "in testAsciiCharset()", expectedResult.length(), result.length());
assertEquals("baos1 and baos2 should be the same in testAsciiCharset()",
baos1.toString(), baos2.toString()); // order of headers cannot be guaranteed
assertFalse(testMailClient.getFailMessage(), testMailClient.isFailed());