You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/28 06:18:38 UTC

[GitHub] [commons-fileupload] jGauravGupta opened a new pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

jGauravGupta opened a new pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25


   Signed-off-by: Gaurav Gupta <ga...@gmail.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-639102893


   @jGauravGupta As a housekeeping issue, please be so kind to close this PR.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jGauravGupta commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-620463450


   Hi @rmannibucau,
   
   This PR can be closed in favor of #26.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jGauravGupta closed pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
jGauravGupta closed pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-620406318


   
   [![Coverage Status](https://coveralls.io/builds/30391412/badge)](https://coveralls.io/builds/30391412)
   
   Coverage remained the same at 78.824% when pulling **29b9739d1b7cf47e64648a35c84a5fddbeb300bc on jGauravGupta:jakarta-servlet-api** into **487e7a35fb1b4976deb589cbe2be2b850cb68bd8 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] rmannibucau commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-620405418


   Hi @jGauravGupta ,
   
   Tihs looks like an invasive breaking change for end users so would require to upgrade the version to a new major + almost nobody migrated to jakarta namespace since it is not yet a thing.
   
   What about the compromise picked by some other project to deliver another artifact where javax is replaced by jakarta but keep the primary artifact as a javax one.
   You can do it just adding shade plugin, see this example for johnzon: https://github.com/apache/johnzon/blob/master/pom.xml#L99
   
   Maybe a compromise to investigate which will enable jakarta usage without breaking all javax users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jGauravGupta commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-639263436


   Thanks @jochenw for adding the Jakarta Servlet support, I will check with Woodstock build and create the issue here, if needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #25: javax.servlet.* to jakarta.servlet.* namespace transition

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #25:
URL: https://github.com/apache/commons-fileupload/pull/25#issuecomment-623425886


   Please check, whether commit cd031805d2618b0c1dd9c90265ebea1a1ce85387 isn't essentially, what you need. If so, please close this PR.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org