You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/29 09:53:07 UTC
[GitHub] [maven-site] apeteri opened a new pull request #276: Add import order configuration for Eclipse
apeteri opened a new pull request #276:
URL: https://github.com/apache/maven-site/pull/276
Related to MNGSITE-465; the configuration matches the screenshot seen in https://github.com/apache/maven-site/pull/269#issuecomment-945622992 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] apeteri commented on pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
apeteri commented on pull request #276:
URL: https://github.com/apache/maven-site/pull/276#issuecomment-981513569
License header and documentation snippets added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #276:
URL: https://github.com/apache/maven-site/pull/276#discussion_r778423535
##########
File path: content/resources/developers/maven-eclipse.importorder
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#Organize Import Order
+#Mon Nov 29 10:45:56 CET 2021
+0=javax
+1=java
+2=
+3=\#
Review comment:
The convention is:
```
import javax.*
blank line
import java.*
blank line
import all other imports
blank line
import static all other imports
```
does this configuration cover it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] apeteri commented on a change in pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
apeteri commented on a change in pull request #276:
URL: https://github.com/apache/maven-site/pull/276#discussion_r778641166
##########
File path: content/resources/developers/maven-eclipse.importorder
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#Organize Import Order
+#Mon Nov 29 10:45:56 CET 2021
+0=javax
+1=java
+2=
+3=\#
Review comment:
The order of import groups is the same; blank lines are controlled in a different section (Preferences → Java → Code Style → Formatter) that describes all Java formatting rules.
The screenshot shows the default profile which specifies a single blank line between import groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #276:
URL: https://github.com/apache/maven-site/pull/276#issuecomment-981483587
Where is reference to this file and instruction how to use?
ASF license should be placed in file header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #276:
URL: https://github.com/apache/maven-site/pull/276#issuecomment-1005499050
Thanks.
Can you also look at:
https://issues.apache.org/jira/browse/MNGSITE-469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski merged pull request #276: Add import order configuration for Eclipse
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #276:
URL: https://github.com/apache/maven-site/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org