You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:25:22 UTC

[GitHub] [shardingsphere] strongduanmu commented on issue #8003: Discuss Merge StatementSQLVisitor into same one or use lots of minor visitor to handle SQL segment

strongduanmu commented on issue #8003:
URL: https://github.com/apache/shardingsphere/issues/8003#issuecomment-721233969


   @terrymanu I think the first way is more convenient to use, and there is no need to worry about calls between different statements. In the second way, we may design a reasonable structure at the beginning to facilitate the reuse of code blocks. But with the support of more statements, we will find that one statement block calls another statement block, which makes us have to repeatedly rewrite these codes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org