You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by david-barth-canonical <gi...@git.apache.org> on 2015/09/07 17:40:47 UTC
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-lib/pull/299
icon parameter should not be relative to the www directory on Ubuntu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit 4aa92493c36fef07415a0d0e6690464b2d21bd51
Author: David Barth <da...@canonical.com>
Date: 2015-09-07T15:38:27Z
change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
Posted by tsschaffert <gi...@git.apache.org>.
Github user tsschaffert commented on the pull request:
https://github.com/apache/cordova-lib/pull/299#issuecomment-142535031
Shouldn't this be handled similar to how it is done in the manifest generation of cordova-ubuntu? Then the 'www' part should be replaced by '../..' (otherwise icons in a top-level res folder are not found).
See https://github.com/apache/cordova-ubuntu/blob/master/bin/templates/project/cordova/lib/manifest.js#L48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
Posted by david-barth-canonical <gi...@git.apache.org>.
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241
Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org