You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/04/08 07:48:11 UTC

[PR] Pipe: Fix receiver can not delete file on thread exit if files in dir are not loaded successfully [iotdb]

SteveYurongSu opened a new pull request, #12302:
URL: https://github.com/apache/iotdb/pull/12302

   As title.
   
   ![image](https://github.com/apache/iotdb/assets/30497621/a07b51d9-eae4-4d2d-8aef-2cbd724e0ea6)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pipe: Fix receiver can not delete dir on thread exit if files in dir are not loaded successfully [iotdb]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12302:
URL: https://github.com/apache/iotdb/pull/12302#issuecomment-2042099325

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12302) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12302&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12302)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pipe: Fix receiver can not delete dir on thread exit if files in dir are not loaded successfully [iotdb]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12302:
URL: https://github.com/apache/iotdb/pull/12302#issuecomment-2042189667

   ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12302?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `2.30769%` with `127 lines` in your changes are missing coverage. Please review.
   > Project coverage is 46.55%. Comparing base [(`e8d11ce`)](https://app.codecov.io/gh/apache/iotdb/commit/e8d11ce91b871fcc41dceecd54b09a6089310da6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7fc89bb`)](https://app.codecov.io/gh/apache/iotdb/pull/12302?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12302?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...iotdb/commons/pipe/receiver/IoTDBFileReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Freceiver%2FIoTDBFileReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9yZWNlaXZlci9Jb1REQkZpbGVSZWNlaXZlci5qYXZh) | 2.70% | [108 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ipe/receiver/protocol/IoTDBConfigNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Freceiver%2Fprotocol%2FIoTDBConfigNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC9Jb1REQkNvbmZpZ05vZGVSZWNlaXZlci5qYXZh) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...eceiver/protocol/thrift/IoTDBDataNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fprotocol%2Fthrift%2FIoTDBDataNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC90aHJpZnQvSW9UREJEYXRhTm9kZVJlY2VpdmVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12302      +/-   ##
   ============================================
   - Coverage     46.55%   46.55%   -0.01%     
     Complexity       69       69              
   ============================================
     Files          3364     3364              
     Lines        206785   206848      +63     
     Branches      24903    24911       +8     
   ============================================
   + Hits          96279    96290      +11     
   - Misses       110506   110558      +52     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12302?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pipe: Fix receiver can not delete dir on thread exit if files in dir are not loaded successfully [iotdb]

Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #12302:
URL: https://github.com/apache/iotdb/pull/12302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org