You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ki...@apache.org on 2014/11/03 13:00:21 UTC

[2/3] git commit: updated refs/heads/master to e427d00

CLOUDSTACK-7265: For LXC volumes, show unsupported operation error for volume snapshot


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/99010f46
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/99010f46
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/99010f46

Branch: refs/heads/master
Commit: 99010f463be44faf07b615f8644332ef4c3810bc
Parents: d6fdb7c
Author: Kishan Kavala <ki...@apache.org>
Authored: Thu Oct 23 20:13:56 2014 +0530
Committer: Kishan Kavala <ki...@apache.org>
Committed: Mon Nov 3 17:20:00 2014 +0530

----------------------------------------------------------------------
 server/src/com/cloud/storage/VolumeApiServiceImpl.java | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/99010f46/server/src/com/cloud/storage/VolumeApiServiceImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/com/cloud/storage/VolumeApiServiceImpl.java
index 9b2e337..5f237b0 100644
--- a/server/src/com/cloud/storage/VolumeApiServiceImpl.java
+++ b/server/src/com/cloud/storage/VolumeApiServiceImpl.java
@@ -1954,6 +1954,10 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
             throw new InvalidParameterValueException("VolumeId: " + volumeId + " is not in " + Volume.State.Ready + " state but " + volume.getState() + ". Cannot take snapshot.");
         }
 
+        if (ImageFormat.DIR.equals(volume.getFormat())){
+            throw new InvalidParameterValueException("Snapshot not supported for volume:" + volumeId);
+        }
+
         if (volume.getTemplateId() != null) {
             VMTemplateVO template = _templateDao.findById(volume.getTemplateId());
             if (template != null && template.getTemplateType() == Storage.TemplateType.SYSTEM) {