You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/03/10 22:38:08 UTC
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6350
to review the following change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
It is enabled by default, and causes the built gflags package to be
"registered" in ~/.cmake/packages (CMake's package registry).
We don't use this feature, and we'd rather not leak build output out of the
Kudu build tree, so let's disable it.
Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/6350/1
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6350/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
PS1, Line 246: -DREGISTER_INSTALL_PREFIX=Off \
should we worry about this for other libs?
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1:
I tested this by removing ~/.cmake, running build-if-necessary.sh, and verifying that ~/.cmake didn't exist afterwards.
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6350/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
PS1, Line 246: -DREGISTER_INSTALL_PREFIX=Off \
> It's a gflags-specific thing.
weird, thanks for clearing that up.
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
It is enabled by default, and causes the built gflags package to be
"registered" in ~/.cmake/packages (CMake's package registry).
We don't use this feature, and we'd rather not leak build output out of the
Kudu build tree, so let's disable it.
Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Reviewed-on: http://gerrit.cloudera.org:8080/6350
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] thirdparty: disable REGISTER INSTALL PREFIX in gflags build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: thirdparty: disable REGISTER_INSTALL_PREFIX in gflags build
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6350/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
PS1, Line 246: -DREGISTER_INSTALL_PREFIX=Off \
> should we worry about this for other libs?
It's a gflags-specific thing.
--
To view, visit http://gerrit.cloudera.org:8080/6350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887da1ff31cb70901c649a83073a6a7ffcc06a3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes