You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/08 03:19:27 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4459: Fix the
wrong nouns in plugin test doc
wu-sheng opened a new pull request #4459: Fix the wrong nouns in plugin test doc
URL: https://github.com/apache/skywalking/pull/4459
@dmsolr I need to head up for you. There is a ref check feature missing in the current version. We are checking the `instance id != 0` today, which is helpful but not enough, we should add service name(entry/parent) translated from the instance id in the mock.
This is not urgent, but should be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4459: Fix the wrong
nouns in plugin test doc
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4459: Fix the wrong nouns in plugin test doc
URL: https://github.com/apache/skywalking/pull/4459#issuecomment-596164133
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=h1) Report
> Merging [#4459](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/da44d28547561634bebe21a202abcfdbc1cf4b21?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4459 +/- ##
==========================================
- Coverage 24.94% 24.94% -0.01%
==========================================
Files 1230 1230
Lines 28490 28490
Branches 3906 3906
==========================================
- Hits 7108 7107 -1
Misses 20725 20725
- Partials 657 658 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4459/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55% <0%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=footer). Last update [da44d28...dc5e193](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4459: Fix the wrong
nouns in plugin test doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4459: Fix the wrong nouns in plugin test doc
URL: https://github.com/apache/skywalking/pull/4459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services