You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/22 14:26:58 UTC
[GitHub] [cloudstack] ravening opened a new pull request #3804: Display capability info in listNetwork response
ravening opened a new pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
## Description
<!--- Describe your changes in detail -->
Display some properties (eg RedundantRouter) in listNetworks response which are initializd in VirtualRouterElement.setCapabilities()
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
listNetworks response for ```StaticNat``` service before the change
```
{
"name": "StaticNat"
},
```
listNetworks response for ```StaticNat``` after the change
```
{
"capability": [
{
"canchooseservicecapability": false,
"name": "ElasticIp",
"value": "false"
},
{
"canchooseservicecapability": false,
"name": "AssociatePublicIP",
"value": "true"
}
],
"name": "StaticNat",
"provider": [
{
"name": "VirtualRouter"
}
]
},
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902604854
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#discussion_r640009777
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -2213,13 +2214,75 @@ public NetworkResponse createNetworkResponse(ResponseView view, Network network)
CapabilityResponse capabilityResponse = new CapabilityResponse();
String capabilityValue = ser_cap_entries.getValue();
capabilityResponse.setName(capability.getName());
- capabilityResponse.setValue(capabilityValue);
+ if (Service.Lb == service && capability.getName().equals(Capability.SupportedLBIsolation.getName())) {
+ capabilityResponse.setValue(networkOffering.isDedicatedLB() ? "dedicated" : "shared");
+ } else {
+ capabilityResponse.setValue(capabilityValue);
+ }
+ if (capability.getName().equals(Capability.SupportedLBIsolation.getName()) || capability.getName().equals(Capability.SupportedSourceNatTypes.getName())
Review comment:
Maybe an alternative would be creating a variable in this class defining a Set of Strings that fit in this conditional.
This would look something similar to:
```
private final Set<String> <insertNameHere> = new HashSet<>(Arrays.asList(Capability.SupportedLBIsolation.getName(),
Capability.SupportedSourceNatTypes.getName(),
Capability.RedundantRouter.getName()));
...
...
...
if (<insertNameHere>.contains(capability.getName())) {
capabilityResponse.setCanChoose(true);
}
...
...
```
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -2213,13 +2214,75 @@ public NetworkResponse createNetworkResponse(ResponseView view, Network network)
CapabilityResponse capabilityResponse = new CapabilityResponse();
String capabilityValue = ser_cap_entries.getValue();
capabilityResponse.setName(capability.getName());
- capabilityResponse.setValue(capabilityValue);
+ if (Service.Lb == service && capability.getName().equals(Capability.SupportedLBIsolation.getName())) {
+ capabilityResponse.setValue(networkOffering.isDedicatedLB() ? "dedicated" : "shared");
+ } else {
+ capabilityResponse.setValue(capabilityValue);
+ }
+ if (capability.getName().equals(Capability.SupportedLBIsolation.getName()) || capability.getName().equals(Capability.SupportedSourceNatTypes.getName())
+ || capability.getName().equals(Capability.RedundantRouter.getName())) {
+ capabilityResponse.setCanChoose(true);
+ } else {
+ capabilityResponse.setCanChoose(false);
+ }
capabilityResponse.setObjectName("capability");
capabilityResponses.add(capabilityResponse);
}
- serviceResponse.setCapabilities(capabilityResponses);
}
+ if (Service.SourceNat == service) {
+ // overwrite
+ capabilityResponses = new ArrayList<CapabilityResponse>();
+ CapabilityResponse sharedSourceNat = new CapabilityResponse();
+ sharedSourceNat.setName(Capability.SupportedSourceNatTypes.getName());
+ sharedSourceNat.setValue(networkOffering.isSharedSourceNat() ? "perzone" : "peraccount");
+ sharedSourceNat.setCanChoose(true);
+ capabilityResponses.add(sharedSourceNat);
+
+ CapabilityResponse redundantRouter = new CapabilityResponse();
+ redundantRouter.setName(Capability.RedundantRouter.getName());
+ redundantRouter.setValue(networkOffering.isRedundantRouter() ? "true" : "false");
+ redundantRouter.setCanChoose(true);
+ capabilityResponses.add(redundantRouter);
+
+ } else if (service == Service.StaticNat) {
+ CapabilityResponse eIp = new CapabilityResponse();
+ eIp.setName(Capability.ElasticIp.getName());
+ eIp.setValue(networkOffering.isElasticIp() ? "true" : "false");
+ eIp.setCanChoose(false);
+ capabilityResponses.add(eIp);
+
+ CapabilityResponse associatePublicIp = new CapabilityResponse();
+ associatePublicIp.setName(Capability.AssociatePublicIP.getName());
+ associatePublicIp.setValue(networkOffering.isAssociatePublicIP() ? "true" : "false");
+ associatePublicIp.setCanChoose(false);
+ capabilityResponses.add(associatePublicIp);
+
+ } else if (Service.Lb == service) {
+ CapabilityResponse eLb = new CapabilityResponse();
+ eLb.setName(Capability.ElasticLb.getName());
+ eLb.setValue(networkOffering.isElasticLb() ? "true" : "false");
+ eLb.setCanChoose(false);
+ capabilityResponses.add(eLb);
+
+ CapabilityResponse inline = new CapabilityResponse();
+ inline.setName(Capability.InlineMode.getName());
+ inline.setValue(networkOffering.isInline() ? "true" : "false");
+ inline.setCanChoose(false);
+ capabilityResponses.add(inline);
Review comment:
I think that it is possible to extract most of the "duplicated" lines by creating a method that returns a CapabilityResponse based on `name`, `value`, and `canChoose`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902604959
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783413612
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-837256093
Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809239855
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-914997876
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-821084001
Re-ping @weizhouapache @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-909119787
Moving to 4.16, as this introduces changes in API response - we'll have more time to review/test this against UI/clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783451056
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-836752464
travis rekick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784098063
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809218669
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902509880
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-806367685
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-922634916
@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-849578203
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-806365736
<b>Trillian test result (tid-252)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53122 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t252-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 76 look OK, 10 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 58.94 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 36.39 | test_affinity_groups.py
test_04_rvpc_privategw_static_routes | `Error` | 0.44 | test_privategw_acl.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 23.64 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 34.23 | test_kubernetes_clusters.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.10 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_hostha_kvm_host_degraded | `Failure` | 677.99 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Failure` | 644.32 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Failure` | 648.34 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-918851041
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-919041461
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-914997395
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-923934071
I'll have a look at it @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-807101321
<b>Trillian test result (tid-258)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t258-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 59.90 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 35.36 | test_affinity_groups.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 24.69 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.16 | test_kubernetes_clusters.py
test_hostha_kvm_host_degraded | `Failure` | 678.33 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Failure` | 643.83 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Failure` | 643.73 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-863921770
re-kick travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-901032732
> @ravening @weizhouapache cc @Pearl1594 should this information be restricted to just admins or to all users?
@rhtyd this can be displayed to both users and admins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-914958308
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-921472933
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-921474847
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783257905
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766760230
> @ravening Moving to 4.16 based on base branch. Please update if needed
made it 4.15 (didn't try 4.14, making assumptions)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-805830978
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-908965784
Ping @Pearl1594 @DaanHoogland can you review/test this, would it cause any leaks or regression (for UI?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-924609182
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-914911848
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-805796817
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813266593
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-836645135
Ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813262351
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783302933
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-814025555
@ravening @weizhouapache cc @Pearl1594 should this information be restricted to just admins or to all users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-923071418
<b>Trillian test result (tid-2123)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38750 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t2123-vmware-65u2.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-923538619
Hi @Pearl1594 can you test this PR for any regressions in the UI given the change on the networks response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783665965
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-923047294
<b>Trillian test result (tid-2122)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36862 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t2122-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-915028826
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#discussion_r691238421
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -2213,13 +2214,75 @@ public NetworkResponse createNetworkResponse(ResponseView view, Network network)
CapabilityResponse capabilityResponse = new CapabilityResponse();
String capabilityValue = ser_cap_entries.getValue();
capabilityResponse.setName(capability.getName());
- capabilityResponse.setValue(capabilityValue);
+ if (Service.Lb == service && capability.getName().equals(Capability.SupportedLBIsolation.getName())) {
+ capabilityResponse.setValue(networkOffering.isDedicatedLB() ? "dedicated" : "shared");
+ } else {
+ capabilityResponse.setValue(capabilityValue);
+ }
+ if (capability.getName().equals(Capability.SupportedLBIsolation.getName()) || capability.getName().equals(Capability.SupportedSourceNatTypes.getName())
+ || capability.getName().equals(Capability.RedundantRouter.getName())) {
+ capabilityResponse.setCanChoose(true);
+ } else {
+ capabilityResponse.setCanChoose(false);
+ }
capabilityResponse.setObjectName("capability");
capabilityResponses.add(capabilityResponse);
}
- serviceResponse.setCapabilities(capabilityResponses);
}
+ if (Service.SourceNat == service) {
+ // overwrite
+ capabilityResponses = new ArrayList<CapabilityResponse>();
+ CapabilityResponse sharedSourceNat = new CapabilityResponse();
+ sharedSourceNat.setName(Capability.SupportedSourceNatTypes.getName());
+ sharedSourceNat.setValue(networkOffering.isSharedSourceNat() ? "perzone" : "peraccount");
+ sharedSourceNat.setCanChoose(true);
+ capabilityResponses.add(sharedSourceNat);
+
+ CapabilityResponse redundantRouter = new CapabilityResponse();
+ redundantRouter.setName(Capability.RedundantRouter.getName());
+ redundantRouter.setValue(networkOffering.isRedundantRouter() ? "true" : "false");
+ redundantRouter.setCanChoose(true);
+ capabilityResponses.add(redundantRouter);
+
+ } else if (service == Service.StaticNat) {
+ CapabilityResponse eIp = new CapabilityResponse();
+ eIp.setName(Capability.ElasticIp.getName());
+ eIp.setValue(networkOffering.isElasticIp() ? "true" : "false");
+ eIp.setCanChoose(false);
+ capabilityResponses.add(eIp);
+
+ CapabilityResponse associatePublicIp = new CapabilityResponse();
+ associatePublicIp.setName(Capability.AssociatePublicIP.getName());
+ associatePublicIp.setValue(networkOffering.isAssociatePublicIP() ? "true" : "false");
+ associatePublicIp.setCanChoose(false);
+ capabilityResponses.add(associatePublicIp);
+
+ } else if (Service.Lb == service) {
+ CapabilityResponse eLb = new CapabilityResponse();
+ eLb.setName(Capability.ElasticLb.getName());
+ eLb.setValue(networkOffering.isElasticLb() ? "true" : "false");
+ eLb.setCanChoose(false);
+ capabilityResponses.add(eLb);
+
+ CapabilityResponse inline = new CapabilityResponse();
+ inline.setName(Capability.InlineMode.getName());
+ inline.setValue(networkOffering.isInline() ? "true" : "false");
+ inline.setCanChoose(false);
+ capabilityResponses.add(inline);
Review comment:
@GabrielBrascher please review it again. made some changes to the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-849959691
<b>Trillian test result (tid-766)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32216 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t766-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-805830606
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-918850092
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813266173
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-805797101
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783956279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783413052
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902494217
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902932512
<b>Trillian test result (tid-1735)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t1735-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-805813265
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813235676
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809240467
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809786667
<b>Trillian test result (tid-280)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46771 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t280-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.98 | test_kubernetes_clusters.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 65.59 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 121.82 | test_routers_network_ops.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_migrate_VM_and_root_volume | `Error` | 70.32 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.05 | test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 494.01 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 481.57 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-908965784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-919712056
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809219543
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-922634713
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766701585
@ravening Moving to 4.16 based on base branch. Please update if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784145577
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783302933
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766760230
> @ravening Moving to 4.16 based on base branch. Please update if needed
made it 4.15 (didn't try 4.14, making assumptions)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784098063
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-914911541
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-806367451
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-919711884
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-923051017
<b>Trillian test result (tid-2121)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t2121-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766701585
@ravening Moving to 4.16 based on base branch. Please update if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#discussion_r691238421
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -2213,13 +2214,75 @@ public NetworkResponse createNetworkResponse(ResponseView view, Network network)
CapabilityResponse capabilityResponse = new CapabilityResponse();
String capabilityValue = ser_cap_entries.getValue();
capabilityResponse.setName(capability.getName());
- capabilityResponse.setValue(capabilityValue);
+ if (Service.Lb == service && capability.getName().equals(Capability.SupportedLBIsolation.getName())) {
+ capabilityResponse.setValue(networkOffering.isDedicatedLB() ? "dedicated" : "shared");
+ } else {
+ capabilityResponse.setValue(capabilityValue);
+ }
+ if (capability.getName().equals(Capability.SupportedLBIsolation.getName()) || capability.getName().equals(Capability.SupportedSourceNatTypes.getName())
+ || capability.getName().equals(Capability.RedundantRouter.getName())) {
+ capabilityResponse.setCanChoose(true);
+ } else {
+ capabilityResponse.setCanChoose(false);
+ }
capabilityResponse.setObjectName("capability");
capabilityResponses.add(capabilityResponse);
}
- serviceResponse.setCapabilities(capabilityResponses);
}
+ if (Service.SourceNat == service) {
+ // overwrite
+ capabilityResponses = new ArrayList<CapabilityResponse>();
+ CapabilityResponse sharedSourceNat = new CapabilityResponse();
+ sharedSourceNat.setName(Capability.SupportedSourceNatTypes.getName());
+ sharedSourceNat.setValue(networkOffering.isSharedSourceNat() ? "perzone" : "peraccount");
+ sharedSourceNat.setCanChoose(true);
+ capabilityResponses.add(sharedSourceNat);
+
+ CapabilityResponse redundantRouter = new CapabilityResponse();
+ redundantRouter.setName(Capability.RedundantRouter.getName());
+ redundantRouter.setValue(networkOffering.isRedundantRouter() ? "true" : "false");
+ redundantRouter.setCanChoose(true);
+ capabilityResponses.add(redundantRouter);
+
+ } else if (service == Service.StaticNat) {
+ CapabilityResponse eIp = new CapabilityResponse();
+ eIp.setName(Capability.ElasticIp.getName());
+ eIp.setValue(networkOffering.isElasticIp() ? "true" : "false");
+ eIp.setCanChoose(false);
+ capabilityResponses.add(eIp);
+
+ CapabilityResponse associatePublicIp = new CapabilityResponse();
+ associatePublicIp.setName(Capability.AssociatePublicIP.getName());
+ associatePublicIp.setValue(networkOffering.isAssociatePublicIP() ? "true" : "false");
+ associatePublicIp.setCanChoose(false);
+ capabilityResponses.add(associatePublicIp);
+
+ } else if (Service.Lb == service) {
+ CapabilityResponse eLb = new CapabilityResponse();
+ eLb.setName(Capability.ElasticLb.getName());
+ eLb.setValue(networkOffering.isElasticLb() ? "true" : "false");
+ eLb.setCanChoose(false);
+ capabilityResponses.add(eLb);
+
+ CapabilityResponse inline = new CapabilityResponse();
+ inline.setName(Capability.InlineMode.getName());
+ inline.setValue(networkOffering.isInline() ? "true" : "false");
+ inline.setCanChoose(false);
+ capabilityResponses.add(inline);
Review comment:
@GabrielBrascher please review it again. made some changes to the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809238010
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813576373
<b>Trillian test result (tid-347)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36633 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3804-t347-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 69.95 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 69.26 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.04 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783258388
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-901032732
> @ravening @weizhouapache cc @Pearl1594 should this information be restricted to just admins or to all users?
@rhtyd this can be displayed to both users and admins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-813236051
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-909119787
Moving to 4.16, as this introduces changes in API response - we'll have more time to review/test this against UI/clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-809329345
Code LGTM. verified the output of listnetworks. Waiting for the test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783956279
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3804:
URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902494645
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org