You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/05/06 03:14:18 UTC
[GitHub] [curator] tisonkun opened a new pull request, #461: CURATOR-XXX. Ensure JDK 17 support
tisonkun opened a new pull request, #461:
URL: https://github.com/apache/curator/pull/461
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #461: CURATOR-XXX. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #461:
URL: https://github.com/apache/curator/pull/461#issuecomment-1537087902
Creating a JIRA ticket ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #461: CURATOR-XXX. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #461:
URL: https://github.com/apache/curator/pull/461#issuecomment-1537088043
... also cc @nicoloboschi @martin-g the original thread participants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #461: CURATOR-672. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #461:
URL: https://github.com/apache/curator/pull/461#issuecomment-1537593013
Since we have three parallel workflows, I'm starting to investigate reduce tests time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #461: CURATOR-672. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #461:
URL: https://github.com/apache/curator/pull/461#issuecomment-1537592850
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a diff in pull request #461: CURATOR-672. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #461:
URL: https://github.com/apache/curator/pull/461#discussion_r1186858278
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -15,5 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip
-wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip
Review Comment:
OK. Let me try to upgrade here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] kezhuw commented on a diff in pull request #461: CURATOR-672. Ensure JDK 17 support
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on code in PR #461:
URL: https://github.com/apache/curator/pull/461#discussion_r1186851135
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -15,5 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip
-wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip
Review Comment:
Just in case, [3.9.1](https://maven.apache.org/docs/3.9.1/release-notes.html) is newest patch release. Seems that it solves two connection related issues [MNG-7708](https://issues.apache.org/jira/browse/MNG-7708) and [MNG-7721](https://issues.apache.org/jira/browse/MNG-7721).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #461: CURATOR-672. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #461:
URL: https://github.com/apache/curator/pull/461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #461: CURATOR-XXX. Ensure JDK 17 support
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #461:
URL: https://github.com/apache/curator/pull/461#issuecomment-1537080919
Jersey bumping is still tricky. Given it's not required for supporting JDK 17, I'll postpone those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org