You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Guangtai Liang (Created) (JIRA)" <xe...@xml.apache.org> on 2012/02/13 08:08:59 UTC
[jira] [Created] (XERCESJ-1551) An incomplete fix for the NPE bugs
in XSWildcardDecl.java
An incomplete fix for the NPE bugs in XSWildcardDecl.java
---------------------------------------------------------
Key: XERCESJ-1551
URL: https://issues.apache.org/jira/browse/XERCESJ-1551
Project: Xerces2-J
Issue Type: Bug
Components: Other
Reporter: Guangtai Liang
Priority: Critical
The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").
The buggy code locations are as bellows:
Lines 91, 93, 103, and 105 of the method "allowNamespace";
Line 137 of the method "isSubsetOf";
Lines 379 and 383 of the method "performIntersectionWith"
Lines 404, 410, and 411 of the method "areSame"
Lines 488, 493, 497, 499, 501, and 502 of the method "toString";
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] [Resolved] (XERCESJ-1551) An incomplete fix for the NPE bugs
in XSWildcardDecl.java
Posted by "Michael Glavassevich (Resolved) (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glavassevich resolved XERCESJ-1551.
-------------------------------------------
Resolution: Incomplete
Please provide test cases which demonstrate that there are actual problems with these methods.
> An incomplete fix for the NPE bugs in XSWildcardDecl.java
> ---------------------------------------------------------
>
> Key: XERCESJ-1551
> URL: https://issues.apache.org/jira/browse/XERCESJ-1551
> Project: Xerces2-J
> Issue Type: Bug
> Components: Other
> Reporter: Guangtai Liang
> Priority: Critical
> Labels: incomplete_fix, missing_fixes
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
> Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").
> The buggy code locations are as bellows:
> Lines 91, 93, 103, and 105 of the method "allowNamespace";
> Line 137 of the method "isSubsetOf";
> Lines 379 and 383 of the method "performIntersectionWith"
> Lines 404, 410, and 411 of the method "areSame"
> Lines 488, 493, 497, 499, 501, and 502 of the method "toString";
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] [Reopened] (XERCESJ-1551) An incomplete fix for the NPE bugs
in XSWildcardDecl.java
Posted by "Guangtai Liang (Reopened) (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guangtai Liang reopened XERCESJ-1551:
-------------------------------------
Please take a look at the log message of revision 319317, which showed that fNamespaceList should be null-checked before dereference.
"Revision: 319317
Author: neilg
Date: 23:14:43, 2003年7月24日
Message:
fixes for various small bugs (potential NPEs, problems in certain situations with well-formedness of annotation strings) in our PSVI/schema component model support. Patches by Peter McCracken.
"
> An incomplete fix for the NPE bugs in XSWildcardDecl.java
> ---------------------------------------------------------
>
> Key: XERCESJ-1551
> URL: https://issues.apache.org/jira/browse/XERCESJ-1551
> Project: Xerces2-J
> Issue Type: Bug
> Components: Other
> Reporter: Guangtai Liang
> Priority: Critical
> Labels: incomplete_fix, missing_fixes
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
> Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").
> The buggy code locations are as bellows:
> Lines 91, 93, 103, and 105 of the method "allowNamespace";
> Line 137 of the method "isSubsetOf";
> Lines 379 and 383 of the method "performIntersectionWith"
> Lines 404, 410, and 411 of the method "areSame"
> Lines 488, 493, 497, 499, 501, and 502 of the method "toString";
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
[jira] [Resolved] (XERCESJ-1551) An incomplete fix for the NPE bugs
in XSWildcardDecl.java
Posted by "Michael Glavassevich (Resolved) (JIRA)" <xe...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XERCESJ-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Glavassevich resolved XERCESJ-1551.
-------------------------------------------
Resolution: Incomplete
Pointing to a commit made years ago doesn't imply that there's an issue today. Please provide an actual test case which demonstrates a problem with the current code base.
> An incomplete fix for the NPE bugs in XSWildcardDecl.java
> ---------------------------------------------------------
>
> Key: XERCESJ-1551
> URL: https://issues.apache.org/jira/browse/XERCESJ-1551
> Project: Xerces2-J
> Issue Type: Bug
> Components: Other
> Reporter: Guangtai Liang
> Priority: Critical
> Labels: incomplete_fix, missing_fixes
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> The fix revision 319317 was aimed to remove an NPE bug on the "fNamespaceList" in the method "getNsConstraintList" of the file "/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSWildcardDecl.java" , but it is incomplete.
> Since the "fNamespaceList" is a class field and also could be null during the run-time execution, it should also be null-checked before being dereferenced in other methods (e.g., Line 1311 in the method "checkFacets").
> The buggy code locations are as bellows:
> Lines 91, 93, 103, and 105 of the method "allowNamespace";
> Line 137 of the method "isSubsetOf";
> Lines 379 and 383 of the method "performIntersectionWith"
> Lines 404, 410, and 411 of the method "areSame"
> Lines 488, 493, 497, 499, 501, and 502 of the method "toString";
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org