You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2025/02/19 15:05:25 UTC
[PR] Fix wrongly check if the migrating slot in the source node [kvrocks-controller]
git-hulk opened a new pull request, #269:
URL: https://github.com/apache/kvrocks-controller/pull/269
Kvrocks will return `migrating_slot(s)` instead of `migrating_slot`
after the slot range migration is supported. From the controller, we
need to allow both of them to be compatible with the old behavior.
This close #267.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix wrongly check if the migrating slot in the source node [kvrocks-controller]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #269:
URL: https://github.com/apache/kvrocks-controller/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix wrongly check if the migrating slot in the source node [kvrocks-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #269:
URL: https://github.com/apache/kvrocks-controller/pull/269#issuecomment-2668969898
## [Codecov](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `25.00000%` with `6 lines` in your changes missing coverage. Please review.
> Project coverage is 47.01%. Comparing base [(`6c56470`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/6c564700d621ef30a182bad1bfeff0aa13db6ea7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e5d00fd`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/e5d00fd9c6a0eee847dcb34f128a8817c77b0d42?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 42 commits behind head on unstable.
| [Files with missing lines](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [controller/cluster.go](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269?src=pr&el=tree&filepath=controller%2Fcluster.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9jbHVzdGVyLmdv) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## unstable #269 +/- ##
============================================
+ Coverage 43.38% 47.01% +3.62%
============================================
Files 37 45 +8
Lines 2971 4222 +1251
============================================
+ Hits 1289 1985 +696
- Misses 1544 2029 +485
- Partials 138 208 +70
```
| [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.01% <25.00%> (+3.62%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kvrocks-controller/pull/269?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org