[GitHub] [httpcomponents-core] ok2c commented on pull request #330: Use Args for argument check.

[GitBox <gi...@apache.org>]

ok2c commented on pull request #330:
URL: https://github.com/apache/httpcomponents-core/pull/330#issuecomment-968281130


   @arturobernalg For love of all that is holy to you, please channel your time and effort into something more useful. Why would you want to replace a simple `not null` check with a utility method that does a whole bunch of `instanceof` checks internally? Why? HttpCore is a low level library. It needs to be reasonably memory and execution efficient. All those unnecessary checks and heap garbage add up. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org