You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/06/25 19:56:01 UTC
[GitHub] [samza] cameronlee314 opened a new pull request #1396: SAMZA-2551: Upgrade all modules to automatically use checkstyle 6.11.2 (part 5: includes samza-yarn, samza-rest)
cameronlee314 opened a new pull request #1396:
URL: https://github.com/apache/samza/pull/1396
Issues: The samza-yarn and samza-rest modules never had checkstyle enabled, so it was inconsistent with Samza checkstyle.
Changes: Enable checkstyle for samza-yarn and samza-rest and make the code consistent with checkstyle.
Tests: Ran compilation and unit tests.
API/Upgrade/Usage changes: N/A
Note for reviewers: There is no expected change in functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 commented on a change in pull request #1396: SAMZA-2551: Upgrade all modules to automatically use checkstyle 6.11.2 (part 5: includes samza-yarn, samza-rest)
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1396:
URL: https://github.com/apache/samza/pull/1396#discussion_r447180551
##########
File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/FileSystemImplConfig.java
##########
@@ -20,11 +20,7 @@
import java.util.ArrayList;
import java.util.List;
-import java.util.Set;
-import org.apache.commons.lang.StringUtils;
import org.apache.samza.config.Config;
-import org.slf4j.Logger;
Review comment:
Our checkstyle does have an unused imports check, but these files never had checkstyle enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] abhishekshivanna commented on a change in pull request #1396: SAMZA-2551: Upgrade all modules to automatically use checkstyle 6.11.2 (part 5: includes samza-yarn, samza-rest)
Posted by GitBox <gi...@apache.org>.
abhishekshivanna commented on a change in pull request #1396:
URL: https://github.com/apache/samza/pull/1396#discussion_r447126456
##########
File path: samza-rest/src/main/java/org/apache/samza/rest/proxy/task/TaskProxyFactory.java
##########
@@ -33,8 +31,7 @@
public interface TaskProxyFactory {
/**
- *
- * @param config the {@link Config} to pass to the proxy.
+ * @param config the config to pass to the proxy.
Review comment:
maybe we can link it to the class that is used just like before?
```{@link org.apache.samza.rest.proxy.task.TaskResourceConfig}```
##########
File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/FileSystemImplConfig.java
##########
@@ -20,11 +20,7 @@
import java.util.ArrayList;
import java.util.List;
-import java.util.Set;
-import org.apache.commons.lang.StringUtils;
import org.apache.samza.config.Config;
-import org.slf4j.Logger;
Review comment:
This is mostly for my own understanding - don't we already have an "unused imports" check during build?
Or was the check somehow not being applied to these files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 merged pull request #1396: SAMZA-2551: Upgrade all modules to automatically use checkstyle 6.11.2 (part 5: includes samza-yarn, samza-rest)
Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1396:
URL: https://github.com/apache/samza/pull/1396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org